Skip to content

Commit a47bd37

Browse files
authored
Merge pull request #367 from datalust/dev
2024.3 Maintenance Release 2
2 parents 4eec6ac + 8c0e0e2 commit a47bd37

35 files changed

+766
-187
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,3 +287,6 @@ __pycache__/
287287
*.xsd.cs
288288

289289
.DS_Store
290+
291+
# ci.global.json is used in CI; local builds are unconstrained
292+
global.json

Build.ps1

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,32 @@ function Publish-Docs($version)
7878
if($LASTEXITCODE -ne 0) { throw "Build failed" }
7979
}
8080

81+
function Remove-GlobalJson
82+
{
83+
if(Test-Path ./global.json) { rm ./global.json }
84+
}
85+
86+
function Create-GlobalJson
87+
{
88+
# It's very important that SeqCli use the same .NET SDK version as its matching Seq version, to avoid
89+
# container and installer bloat. But, highly-restrictive global.json files are annoying during development. So,
90+
# we create a temporary global.json from ci.global.json to use during CI builds.
91+
Remove-GlobalJson
92+
cp ./ci.global.json global.json
93+
}
94+
8195
Write-Output "Building version $version"
8296

8397
$env:Path = "$pwd/.dotnetcli;$env:Path"
8498

8599
Clean-Output
86100
Create-ArtifactDir
101+
Create-GlobalJson
87102
Restore-Packages
88103
Publish-Archives($version)
89104
Publish-DotNetTool($version)
90105
Execute-Tests($version)
91106
Publish-Docs($version)
107+
Remove-GlobalJson
92108

93109
Pop-Location

README.md

Lines changed: 307 additions & 6 deletions
Large diffs are not rendered by default.

Setup.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
$ErrorActionPreference = "Stop"
22

3-
$RequiredDotnetVersion = $(cat ./global.json | convertfrom-json).sdk.version
3+
$RequiredDotnetVersion = $(cat ./ci.global.json | convertfrom-json).sdk.version
44

55
New-Item -ItemType Directory -Force "./build/" | Out-Null
66

ci.global.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"sdk": {
3+
"version": "8.0.303"
4+
}
5+
}

global.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

seqcli.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "sln", "sln", "{2EA56595-519
1010
.gitignore = .gitignore
1111
appveyor.yml = appveyor.yml
1212
Build.ps1 = Build.ps1
13-
global.json = global.json
1413
LICENSE = LICENSE
1514
README.md = README.md
1615
setup.sh = setup.sh
1716
Build.Docker.ps1 = Build.Docker.ps1
1817
docker-publish.ps1 = docker-publish.ps1
1918
Setup.ps1 = Setup.ps1
2019
CONTRIBUTING.md = CONTRIBUTING.md
20+
ci.global.json = ci.global.json
2121
EndProjectSection
2222
EndProject
2323
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "test", "test", "{3587B633-0C03-4235-8903-6226900328F1}"

setup.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ set -o pipefail
77
sudo apt-get update || true
88
sudo apt-get install -y --no-install-recommends jq
99

10-
RequiredDotnetVersion=$(jq -r '.sdk.version' global.json)
10+
RequiredDotnetVersion=$(jq -r '.sdk.version' ci.global.json)
1111

1212
curl https://dot.net/v1/dotnet-install.sh -sSfL --output dotnet-install.sh
1313
chmod +x dotnet-install.sh

src/Roastery/Roastery.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
</PropertyGroup>
77

88
<ItemGroup>
9-
<PackageReference Include="Serilog" Version="3.1.1" />
10-
<PackageReference Include="SerilogTracing" Version="1.0.0" />
9+
<PackageReference Include="Serilog" Version="4.0.2" />
10+
<PackageReference Include="SerilogTracing" Version="2.1.2" />
1111
</ItemGroup>
1212

1313
</Project>

src/SeqCli/Cli/Commands/ApiKey/CreateCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public CreateCommand(SeqConnectionFactory connectionFactory, SeqCliConfig config
7575

7676
Options.Add(
7777
"permissions=",
78-
"A comma-separated list of permissions to delegate to the API key; valid permissions are `Ingest` (default), `Read`, `Write`, `Project` and `System`",
78+
"A comma-separated list of permissions to delegate to the API key; valid permissions are `Ingest` (default), `Read`, `Write`, `Project`, `Organization`, and `System`",
7979
v => _permissions = ArgumentString.NormalizeList(v));
8080

8181
Options.Add(
@@ -133,7 +133,7 @@ protected override async Task<int> Run()
133133
{
134134
foreach (var permission in _permissions)
135135
{
136-
if (!Enum.TryParse<Permission>(permission, out var p))
136+
if (!Enum.TryParse<Permission>(permission, true, out var p))
137137
{
138138
Log.Error("Unrecognized permission {Permission}", permission);
139139
return 1;

0 commit comments

Comments
 (0)