Remove redundant try/catch block

nblumhardt · nblumhardt · commit ba6ec0355ec2 · 2025-04-24T15:28:39.000+10:00
diff --git a/src/SeqCli/Cli/Commands/Node/HealthCommand.cs b/src/SeqCli/Cli/Commands/Node/HealthCommand.cs
@@ -22,7 +22,6 @@
 using SeqCli.Cli.Features;
 using SeqCli.Config;
 using SeqCli.Connection;
-using SeqCli.Util;
 using Serilog;
 
 namespace SeqCli.Cli.Commands.Node;
@@ -77,16 +76,9 @@ async Task<int> RunUntilHealthy(SeqConnection connection, TimeSpan timeout)
             {
                 while (true)
                 {
-                    try
+                    if (await RunOnce(connection) == 0)
                     {
-                        if (await RunOnce(connection) == 0)
-                        {
-                            return 0;
-                        }
-                    }
-                    catch (Exception ex)
-                    {
-                        Log.Error("{UnhandledExceptionMessage}", Presentation.FormattedMessage(ex));
+                        return 0;
                     }
 
                     await Task.Delay(tick, ct.Token);

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@`
`22`	`22`	`using SeqCli.Cli.Features;`
`23`	`23`	`using SeqCli.Config;`
`24`	`24`	`using SeqCli.Connection;`
`25`		`-using SeqCli.Util;`
`26`	`25`	`using Serilog;`
`27`	`26`
`28`	`27`	`namespace SeqCli.Cli.Commands.Node;`
`@@ -77,16 +76,9 @@ async Task<int> RunUntilHealthy(SeqConnection connection, TimeSpan timeout)`
`77`	`76`	`{`
`78`	`77`	`while (true)`
`79`	`78`	`{`
`80`		`- try`
	`79`	`+ if (await RunOnce(connection) == 0)`
`81`	`80`	`{`
`82`		`- if (await RunOnce(connection) == 0)`
`83`		`- {`
`84`		`- return 0;`
`85`		`- }`
`86`		`- }`
`87`		`- catch (Exception ex)`
`88`		`- {`
`89`		`- Log.Error("{UnhandledExceptionMessage}", Presentation.FormattedMessage(ex));`
	`81`	`+ return 0;`
`90`	`82`	`}`
`91`	`83`
`92`	`84`	`await Task.Delay(tick, ct.Token);`