Skip to content

Commit 0d36065

Browse files
SQLDBAWithABeardjpomfretNowinskiK
authored
Updating docs for links to issues and coding guidelines closes #13 (#124)
* Update CONTRIBUTING.md to enhance clarity and resources Improved the documentation by adding links to coding guidelines, bug reporting, feature requests, and discussion sections. Clarified the Pull Request workflow and bug reporting process to assist contributors in navigating the project more effectively. Thank you for your contributions! * Update PR template to clarify submission guidelines This update enhances the Pull Request template by specifying that titles should prepend with the [DscResourceName] for DSC resource-specific PRs. Additionally, it emphasizes the importance of submitting atomic PRs and following contribution guidelines. Thank you! * better wording Co-authored-by: Jess Pomfret <[email protected]> Signed-off-by: Rob Sewell <[email protected]> * better punctuation Co-authored-by: Jess Pomfret <[email protected]> Signed-off-by: Rob Sewell <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Kamil Nowinski <[email protected]> Signed-off-by: Rob Sewell <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Kamil Nowinski <[email protected]> Signed-off-by: Rob Sewell <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Kamil Nowinski <[email protected]> Signed-off-by: Rob Sewell <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Kamil Nowinski <[email protected]> Signed-off-by: Rob Sewell <[email protected]> * reverted change to return to original wording and fixed broken URL --------- Signed-off-by: Rob Sewell <[email protected]> Co-authored-by: Jess Pomfret <[email protected]> Co-authored-by: Kamil Nowinski <[email protected]>
1 parent 1e3e51d commit 0d36065

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@
55
Your contribution to this project is greatly appreciated!
66
77
TITLE: Please be descriptive not sensationalist.
8-
Prepend the title with the [DscResourceName] if your PR is specific to a DSC resource.
98
Also prepend with [BREAKING CHANGE] if relevant.
109
i.e. [BREAKING CHANGE][xFile] Add security descriptor property
1110
1211
You may remove this comment block, and the other comment blocks, but please
1312
keep the headers and the task list.
1413
Try to keep your PRs atomic: changes grouped in smallest batch affecting a single logical unit.
14+
15+
PLEASE DO NOT submit PRs that contain multiple unrelated changes.
16+
If you have multiple changes, please submit them in separate PRs.
1517
-->
1618

1719
## Pull Request (PR) description
@@ -59,4 +61,4 @@
5961
- [ ] Unit tests added/updated..
6062
- [ ] Integration tests added/updated (where possible).
6163
- [ ] Documentation added/updated (where applicable).
62-
- [ ] Code follows the [contribution guidelines](../CONTRIBUTING.md).
64+
- [ ] Code follows the [contribution guidelines](https://github.com/dataplat/FabricTools/blob/develop/CONTRIBUTING.md).

CONTRIBUTING.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@ Before we go any further, thanks for being here. Thanks for using the module and
66

77
## Important resources
88

9-
- docs TODO: link to docs
10-
- bugs TODO: link to issues issue template
9+
- Documentation such as coding guidelines can be found in the [wiki](https://github.com/dataplat/FabricTools/wiki)
10+
- Bugs can be reported as [issues](https://github.com/dataplat/FabricTools/issues) via the bug issue template.
11+
- Feature requests can be submitted in the issues via the feature request issue template.
12+
- Discussions can be started in the [Discussions](https://github.com/dataplat/FabricTools/discussions) section of the repository.
1113
- communicate via issues, PRs, and discussions as well as the project
1214

1315
## Develop & Build
@@ -113,23 +115,19 @@ If you have any questions or need help, please feel free to reach out to us on t
113115

114116
## How to submit changes
115117

116-
TODO:
117-
Pull Request protocol etc. You might also include what response they'll get back from the team on submission, or any caveats about the speed of response.
118+
We use a Pull Request (PR) workflow to manage changes to the module. This means that you will need to create a new branch in your fork of the repository, make your changes, and then create a PR against the main repository. You can find full details in the [wiki](https://github.com/dataplat/FabricTools/wiki)
118119

119120
## How to report a bug
120121

121-
TODO:
122-
Bugs are problems in code, in the functionality of an application or in its UI design; you can submit them through "bug trackers" and most projects invite you to do so, so that they may "debug" with more efficiency and the input of a contributor. Take a look at Atom's example for how to teach people to report bugs to your project.
122+
If you find a bug in the module, please report it using the [issue template](https://github.com/dataplat/FabricTools/issues). This will help us track the issue and ensure that it is fixed in a timely manner.
123123

124124
## Templates
125125

126-
TODO:
127-
in this section of your file, you might also want to link to a bug report "template" like this one here which contributors can copy and add context to; this will keep your bugs tidy and relevant.
126+
There are a number of templates available in the `.github` folder of the repository. These include issue templates for bugs, feature requests, and discussions. You can use these templates to help you create a new issue or discussion.
128127

129128
## Style Guide
130129

131-
TODO:
132-
include extensions and vscode settings we use to keep things neat
130+
The Style Guide is a set of rules and guidelines that we follow to ensure that our code is consistent, readable, and maintainable. It is located in the [wiki](https://github.com/dataplat/FabricTools/wiki).
133131

134132
## Code of Conduct
135133

0 commit comments

Comments
 (0)