Merge pull request #152 from dataplat/bug/145-Remove-FabricWarehouse

Fixed misleading message from `Remove-FabricWarehouse` (#145)

Author: NowinskiK

CHANGELOG.md

@@ -33,20 +33,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `Get-FabricSqlDatabase` accepts Workspace as a pipeline, handles errors correctly and can filter by name (#117).
 - Applied splatting for several parameters in `Invoke-FabricRestMethod` and output results in debug mode
 - `Remove-FabricSQLDatabase` uses unified function to handle API results
+- Updated the `WorkspaceId`, `CapacitiesIds`,`CapacityId`,`CopyJobId`,`datamartId`,`DataPipelineId`,`DataWarehouseGUID`,`DomainId`,`EnvironmentId`,`EventhouseId`,`EventstreamId`,`ExternalDataShareId`,`ItemId`,`KQLDashboardId`,`KQLDatabaseId`,`KQLQuerysetId`,`LakehouseId`,`MirroredDatabaseId`,`MirroredWarehouseId`,`MLExperimentId`,`MLModelId`,`NotebookId`,`operationId`,`PaginatedReportId`,`ParentDomainId`,`parentEventhouseId`,`PrincipalId`,`ReflexId`,`ReportId`,`SemanticModelId`,`SparkCustomPoolId`,`SparkJobDefinitionId`,`SQLDatabaseId`,`SQLEndpointId`,`subscriptionID`,`UserId`,`WarehouseId`,`WorkspaceGUID`,`WorkspaceId`,`WorkspaceIds`, and `WorkspaceRoleAssignmentId` parameters to the datatype GUID [#125](https://github.com/dataplat/FabricTools/issues/125)
 - Internal function `Invoke-FabricRestMethod`: (#143)
   - handles API response, no need to use `Test-FabricApiResponse` from parent public function 
   - handles pagination automatically (when `-HandleResponse` is provided)
 - All Deployment Pipeline functions raise an error when an exception is caught. Used splatting for params.
 - Refactored SQL Database functions to use enhanced capability in `Invoke-FabricRestMethod`. Used splatting for params.
 - `Write-Message` uses PSFramework function for logging, which logs function name (#84)
 
-Updated the `WorkspaceId`, `CapacitiesIds`,`CapacityId`,`CopyJobId`,`datamartId`,`DataPipelineId`,`DataWarehouseGUID`,`DomainId`,`EnvironmentId`,`EventhouseId`,`EventstreamId`,`ExternalDataShareId`,`ItemId`,`KQLDashboardId`,`KQLDatabaseId`,`KQLQuerysetId`,`LakehouseId`,`MirroredDatabaseId`,`MirroredWarehouseId`,`MLExperimentId`,`MLModelId`,`NotebookId`,`operationId`,`PaginatedReportId`,`ParentDomainId`,`parentEventhouseId`,`PrincipalId`,`ReflexId`,`ReportId`,`SemanticModelId`,`SparkCustomPoolId`,`SparkJobDefinitionId`,`SQLDatabaseId`,`SQLEndpointId`,`subscriptionID`,`UserId`,`WarehouseId`,`WorkspaceGUID`,`WorkspaceId`,`WorkspaceIds`,and `WorkspaceRoleAssignmentId` parameters to the datatype GUID [#125](https://github.com/dataplat/FabricTools/issues/125)
-
 ### Fixed
 
 - Enhanced logic in unified function `Test-FabricApiResponse` to handle API results and moved it to private functions
-- Fixed bug in `Get-FabricLongRunningOperation` - Uri was incorectly created (#131)
+- Fixed bug in `Get-FabricLongRunningOperation` - Uri was incorrectly created (#131)
 - Fixed bug in `Get-FabricLongRunningOperationResult` - uses correct statusCode (#131)
+- Fixed misleading message from `Remove-FabricWarehouse` (#145)
 - Fixed `Start-FabricDeploymentPipelineStage` that supports `-NoWait` correctly
 
 ### Deprecated

source/Public/Warehouse/Remove-FabricWarehouse.ps1

@@ -17,7 +17,6 @@
     This example removes the warehouse with ID "warehouse-67890" from the workspace with ID "workspace-12345".
 
 .NOTES
-    - Requires `$FabricConfig` global configuration, including `BaseUrl` and `FabricHeaders`.
     - Calls `Confirm-TokenState` to ensure token validity before making the API request.
 
     Author: Tiago Balabuch
@@ -44,14 +43,19 @@ function Remove-FabricWarehouse
 
         if ($PSCmdlet.ShouldProcess($apiEndpointURI, "Delete Warehouse"))
         {
-            # Step 3: Make the API request
-            $response = Invoke-FabricRestMethod `
-                -Uri $apiEndpointURI `
-                -method Delete `
+            # Step 3: Make the API request and Validate the response
+            $apiParameters = @{
+                Uri = $apiEndpointURI
+                Method = 'DELETE'
+                HandleResponse = $true
+                TypeName = "Warehouse"
+                ObjectIdOrName = $WarehouseId
+            }
+            $response = Invoke-FabricRestMethod @apiParameters
         }
 
-        Write-Message -Message "Warehouse '$WarehouseId' deleted successfully from workspace '$WorkspaceId'." -Level Info
-        return $response
+        # Step 4: Handle results
+        $response
 
     }
     catch