fix: Always showed successful message even when it should not #145

NowinskiK · NowinskiK · commit 6eed358b8306 · 2025-07-04T21:44:04.000+01:00
diff --git a/source/Public/Warehouse/Remove-FabricWarehouse.ps1 b/source/Public/Warehouse/Remove-FabricWarehouse.ps1
@@ -44,14 +44,13 @@ function Remove-FabricWarehouse
 
         if ($PSCmdlet.ShouldProcess($apiEndpointURI, "Delete Warehouse"))
         {
-            # Step 3: Make the API request
-            $response = Invoke-FabricRestMethod `
-                -Uri $apiEndpointURI `
-                -method Delete `
+            # Step 3: Make the API request and Validate the response
+            $response = Invoke-FabricRestMethod -Uri $apiEndpointURI -Method Delete
+            $response = Test-FabricApiResponse -response $response -ObjectIdOrName $WarehouseId -typeName "Warehouse"
         }
 
-        Write-Message -Message "Warehouse '$WarehouseId' deleted successfully from workspace '$WorkspaceId'." -Level Info
-        return $response
+        # Step 4: Handle results
+        $response
 
     }
     catch

Original file line number	Diff line number	Diff line change
`@@ -44,14 +44,13 @@ function Remove-FabricWarehouse`
`44`	`44`
`45`	`45`	`if ($PSCmdlet.ShouldProcess($apiEndpointURI, "Delete Warehouse"))`
`46`	`46`	`{`
`47`		`- # Step 3: Make the API request`
`48`		- $response = Invoke-FabricRestMethod `
`49`		- -Uri $apiEndpointURI `
`50`		- -method Delete `
	`47`	`+ # Step 3: Make the API request and Validate the response`
	`48`	`+ $response = Invoke-FabricRestMethod -Uri $apiEndpointURI -Method Delete`
	`49`	`+ $response = Test-FabricApiResponse -response $response -ObjectIdOrName $WarehouseId -typeName "Warehouse"`
`51`	`50`	`}`
`52`	`51`
`53`		`- Write-Message -Message "Warehouse '$WarehouseId' deleted successfully from workspace '$WorkspaceId'." -Level Info`
`54`		`- return $response`
	`52`	`+ # Step 4: Handle results`
	`53`	`+ $response`
`55`	`54`
`56`	`55`	`}`
`57`	`56`	`catch`