Skip to content

Commit ca3f3e2

Browse files
Actions speaker louder than swearing (#108)
* Reorder Send Changelog PR step in deployment workflow Moved the Send Changelog PR step to ensure it runs after setting the Git configuration. This change improves the workflow's reliability by ensuring that the necessary Git settings are applied before attempting to create a changelog pull request. Thank you! * Remove extra blank line in Set-FabricConfig.ps1 This change cleans up the formatting of the Set-FabricConfig.ps1 file by removing an unnecessary blank line. This improves readability and maintains consistency in the code style. Thank you!
1 parent 808d8b5 commit ca3f3e2

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

.github/workflows/deploy-module.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,6 @@ jobs:
7979
env:
8080
GitHubToken: ${{ secrets.GitHubToken }}
8181
GalleryApiToken: ${{ secrets.GalleryApiToken }}
82-
- name: Send Changelog PR
83-
shell: pwsh
84-
run: ./build.ps1 -tasks Create_ChangeLog_GitHub_PR
85-
env:
86-
GitHubToken: ${{ secrets.GitHubToken }}
87-
GalleryApiToken: ${{ secrets.GalleryApiToken }}
88-
ReleaseBranch: main
89-
MainGitBranch: main
9082
- name: Set Git config
9183
run: |
9284
git config --local user.email "[email protected]"
@@ -100,3 +92,11 @@ jobs:
10092
git pull
10193
git merge --no-ff main -m "Auto-merge main back to dev"
10294
git push
95+
- name: Send Changelog PR
96+
shell: pwsh
97+
run: ./build.ps1 -tasks Create_ChangeLog_GitHub_PR
98+
env:
99+
GitHubToken: ${{ secrets.GitHubToken }}
100+
GalleryApiToken: ${{ secrets.GalleryApiToken }}
101+
ReleaseBranch: main
102+
MainGitBranch: main

source/Public/Config/Set-FabricConfig.ps1

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ Registers the specified Fabric Data Warehouse configuration for use with all fun
2626
PS> Set-FabricConfig -WorkspaceGUID 'GUID-GUID-GUID-GUID' -DataWarehouseGUID 'GUID-GUID-GUID-GUID' -SkipPersist
2727
2828
Registers the specified Fabric Data Warehouse configuration for use with all functions in the PSFabricTools module - but does not persist the values, only uses them for the current session.
29-
3029
#>
3130

3231
function Set-FabricConfig {

0 commit comments

Comments
 (0)