Use return in functions or not - that's the question

[NowinskiK]

Should we use return statement in functions to return value(s) or shouldn't?
I'm not fully convinced of not using them (for readability), but I'm happy for us to discuss and agree the best approach.

[jpomfret]

Agreed - no need for return

[NowinskiK]

ok, let's do it then, moving forward for all new functions or functions we are changing for a specific business reason.
We must be careful when making any bulk changes because the latest changes proved that we broke important core functions.
This change should not happen overnight.

[jpomfret]

What core functions broke? Something we could implement pester tests for to ensure stability moving forward?

[NowinskiK]

We have opened PR to fix it: #132

[tiagobalabuch]

The return statement is a helpful feature in PowerShell, especially when you want to control the flow of a function or clearly define its final output. That said, I don't believe it should be treated as a strict requirement. Flexibility is important too.

[SQLDBAWithABeard]

We are only talking about using return to return a value from the function not for any control logic like to exit a loop or a validation.

this is about not using return in this scenario return $variable

[tiagobalabuch]

Sorry for late response! Thanks @SQLDBAWithABeard it is clear for me now.

[NowinskiK]

Let's provide examples Standards, and we will be able to implement a new approach moving forward.