Skip to content

FabricRecoveryPoint functions need alignments to module's pattern #139

@NowinskiK

Description

@NowinskiK

Problem description

It's about a few functions:

  • Get-FabricRecoveryPoint
  • New-FabricRecoveryPoint
  • Restore-FabricRecoveryPoint
  • Remove-FabricRecoveryPoint

I understand they were moved into the project as-is, so now is a good time to start aligning them with the patterns we use in other functions.
It doesn’t have to be a complete refactor right away, but even partial alignment would be a good step forward.

Verbose logs

n/a

Module Version

develop branch

Suggested solution

  1. Recovery Points are related to the Warehouse in Fabric? If so, (sorry, I'm not sure) maybe we should consider renaming the functions by adding Datawarehouse: Get-FabricDatawarehouseRecoveryPoint or Get-FabricWarehouseRecoveryPoint
  2. There are no mandatory/non-mandatory attributes for input parameters
  3. Delete Get-FabricUri and use Invoke-FabricRestMethod instead
  4. Formatting: sometimes no spaces after if
  5. Input parameters should be *Id rather than *GUID
  6. WorkspaceId & DataWarehouseId should be mandatory
  7. Switch param Wait should be replaced by NoWait
  8. .SYNOPSIS & .DESCRIPTION are the same. The latter could be more descriptive.
  9. Use Confirm-TokenState at the beginning of each function

Metadata

Metadata

Assignees

No one assigned

    Labels

    standardizationNo logic changes, but refactoring and alignment to module's patterns

    Type

    No type

    Projects

    Status

    📌 Ready

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions