Merge pull request #935 from dataplat/moreinstancechecks

Some instance checks Some perf fixes, some development fixes

Author: SQLDBAWithABeard

.devcontainer/devcontainer.json

@@ -157,7 +157,6 @@
                 "powershell.codeFolding.enable": true,
                 "powershell.codeFolding.showLastLine": true,
                 "powershell.enableReferencesCodeLens": true,
-                "powershell.powerShellDefaultVersion": "PowerShell Core 7 (x64)",
                 "editor.formatOnSave": true,
                 "editor.formatOnSaveMode": "file",
                 "editor.formatOnPaste": true,
@@ -173,5 +172,5 @@
             }
         }
     },
-    "postCreateCommand": "pwsh -c '/workspace/developing/Howto.md'"
+    "postCreateCommand": ""
 }

containers/JessAndBeard.psm1

@@ -2246,6 +2246,7 @@ function Invoke-PerfAndValidateCheck {
   [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingCmdletAliases', 'cls', Justification = 'Dont tell me what to do')]
   [CmdletBinding()]
   param($Checks, [switch]$PerfDetail , [switch]$showTestResults)
+ $SQLInstances = $dbachecks1, $dbachecks2, $dbachecks3 = 'dbachecks1', 'dbachecks2', 'dbachecks3'
   $password = ConvertTo-SecureString "dbatools.IO" -AsPlainText -Force
   $cred = New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList "sqladmin", $password
   if ($showTestResults) {
@@ -2263,6 +2264,8 @@ function Invoke-PerfAndValidateCheck {
   }
 
   $originalCodetrace = Trace-Script -ScriptBlock $originalCode
+  Remove-Module Pester
+  Import-Module Pester -MinimumVersion 5.0.0 -Global
   $NewCodetrace = Trace-Script -ScriptBlock $NewCode
 
   $originalCodeMessage = "With original Code it takes {0} MilliSeconds" -f $originalCodetrace.StopwatchDuration.TotalMilliseconds
@@ -2434,7 +2437,7 @@ The Total Tests Skipped are the same {0} {1}
       $message = "
     Let's take a look at the slowest code as well "
       Write-PSFMessage -Message $Message -Level Output
-      $NewCodetrace.Top50SelfDuration| Select SelfPercent,HitCount,Line,Function  }
+      $NewCodetrace.Top50SelfDuration| Select SelfPercent,HitCount,Line,Function, Text }
 }
 
 Set-PSFConfig -Module JessAndBeard -Name shallweplayagame -Value $true -Initialize -Description "Whether to ask or not" -ModuleExport

developing/Robs-Instance.ps1

@@ -1,7 +1,14 @@
-$Checks = 'ErrorLogCount', 'TraceFlagsNotExpected', 'TraceFlagsExpected', 'XESessionRunningAllowed', 'XESessionRunning', 'XESessionRunningAllowed', 'XESessionExists', 'XESessionStopped', 'XpCmdShellDisabled', 'WhoIsActiveInstalled', 'CLREnabled', 'TwoDigitYearCutoff', 'MaxDopInstance', 'ErrorLogCount', 'ModelDbGrowth', 'DefaultBackupCompression', 'SaExist', 'SaDisabled', 'SaRenamed', 'DefaultFilePath', 'AdHocDistributedQueriesEnabled', 'AdHocWorkload', 'DefaultTrace', 'OleAutomationProceduresDisabled', 'CrossDBOwnershipChaining', 'ScanForStartupProceduresDisabled', 'RemoteAccessDisabled', 'SQLMailXPsDisabled', 'DAC', 'OLEAutomation'
+$Checks = 'ErrorLogCount', 'XESessionExists', 'XESessionStopped', 'XpCmdShellDisabled', 'WhoIsActiveInstalled', 'CLREnabled', 'TwoDigitYearCutoff', 'MaxDopInstance', 'ErrorLogCount', 'ModelDbGrowth', 'DefaultBackupCompression', 'SaExist', 'SaDisabled', 'SaRenamed', 'DefaultFilePath', 'AdHocDistributedQueriesEnabled', 'AdHocWorkload', 'DefaultTrace', 'OleAutomationProceduresDisabled', 'CrossDBOwnershipChaining', 'ScanForStartupProceduresDisabled', 'RemoteAccessDisabled', 'SQLMailXPsDisabled', 'DAC', 'OLEAutomation', 'ServerNameMatch', 'OrphanedFile', 'MaxMemory', 'NetworkLatency'
 
 $Checks = 'XESessionRunningAllowed', 'XESessionRunning', 'XESessionRunningAllowed', 'XESessionExists', 'XESessionStopped', 'XpCmdShellDisabled'
 $Checks = 'TraceFlagsNotExpected', 'TraceFlagsExpected'
+$Checks = 'ServerNameMatch'
+$Checks = 'BackupPathAccess'
+$Checks = 'LatestBuild'
+$Checks = 'NetworkLatency'
+$Checks = 'LinkedServerConnection'
+$Checks = 'MaxMemory'
+$Checks = 'OrphanedFile'
 
 Invoke-PerfAndValidateCheck -Checks $Checks
 Invoke-PerfAndValidateCheck -Checks $Checks -PerfDetail
@@ -21,6 +28,18 @@ Set-DbcConfig -Name policy.xevent.requiredrunningsession -Value system_health ,
 Set-DbcConfig -Name policy.xevent.validrunningsession -Value system_health , AlwaysOn_health
 Set-DbcConfig -Name policy.xevent.validrunningsession -Value AlwaysOn_health
 
+
+$SQLInstances = $dbachecks1, $dbachecks2, $dbachecks3 = 'dbachecks1', 'dbachecks2', 'dbachecks3'
+$password = ConvertTo-SecureString "dbatools.IO" -AsPlainText -Force
+$cred = New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList "sqladmin", $password
+$show = 'All'
+
 $traci = Trace-Script -ScriptBlock {
     $v5code = Invoke-DbcCheck -SqlInstance $Sqlinstances -SqlCredential $cred -Check $Checks -legacy $false -Show $show -PassThru
-}
+}
+$traci1 = Trace-Script -ScriptBlock {
+    $v5code = Invoke-DbcCheck -SqlInstance $Sqlinstances -SqlCredential $cred -Check $Checks -legacy $false -Show $show -PassThru
+}
+$traci = Trace-Script -ScriptBlock {
+    $v4code = Invoke-DbcCheck -SqlInstance $Sqlinstances -SqlCredential $cred -Check $Checks -legacy $true -Show $show -PassThru
+}