ValidJobOwner

Author: ClaudioESSilva

source/checks/Agentv5.Tests.ps1

@@ -32,7 +32,12 @@ BeforeDiscovery {
         }
     }
 
+    #TODO : Clean this up
     Write-PSFMessage -Message "Instances = $($InstancesToTest.Name)" -Level Verbose
+
+    Write-PSFMessage -Message "JobOwner = $($InstancesToTest.JobOwner)" -Level Verbose
+    Write-PSFMessage -Message "JobOwner = $($InstancesToTest.JobOwner.JobName)" -Level Verbose
+
     Set-PSFConfig -Module dbachecks -Name global.notcontactable -Value $NotContactable
 
     # Get-DbcConfig is expensive so we call it once
@@ -105,15 +110,26 @@ Describe "Database Mail Profile" -Tag DatabaseMailProfile, Agent -ForEach $Insta
 }
 
 Describe "Agent Mail Profile" -Tag AgentMailProfile, Agent -ForEach $InstancesToTest {
-    $skipAgentMailProfile = ($__dbcconfig | Where-Object { $_.Name -eq 'skip.agent.agentmailprofile' }).Value
+    $skipAgentMailProfile = ($__dbcconfig | Where-Object { $_.Name -eq 'skip.agent.mailprofile' }).Value
 
-    Context "esting SQL Agent Alert System database mail profile is set on <_.Name>" {
+    Context "Testing SQL Agent Alert System database mail profile is set on <_.Name>" {
         It "The SQL Server Agent Alert System has the mail profile <_.AgentMailProfile.ExpectedAgentMailProfile> enabled as profile on <_.Name>." -Skip:$skipAgentMailProfile { #-ForEach ($PSItem.DatabaseMailProfile | Where-Object ExpectedDatabaseMailProfile -NE 'null') {
             $PSItem.AgentMailProfile.ActualAgentMailProfile | Should -Be $PSItem.AgentMailProfile.ExpectedAgentMailProfile -Because 'The SQL Agent Alert System needs an enabled database mail profile to send alert emails'
         }
     }
 }
 
+Describe "Valid Job Owner" -Tag ValidJobOwner, Agent -ForEach $InstancesToTest {
+    $skipAgentJobTargetOwner = ($__dbcconfig | Where-Object { $_.Name -eq 'skip.agent.jobowner' }).Value
+
+    Context "Testing SQL Agent Job Owner on <_.Name>" {
+        It "The Job <_.JobName> has the Job Owner <_.ActualJobOwnerName> that should exist in this list ($([String]::Join(', ', "<_.ExpectedJobOwnerName>"))) on <_.InstanceName>" -Skip:$skipAgentJobTargetOwner -ForEach ($PSItem.JobOwner) {
+            $PSItem.ActualJobOwnerName | Should -BeIn $PSItem.ExpectedJobOwnerName -Because 'The account that is the job owner is not what was expected'
+        }
+    }
+}
+
+
 
 
 # Describe "Failed Jobs" -Tags FailedJob, $filename {
@@ -151,26 +167,6 @@ Describe "Agent Mail Profile" -Tag AgentMailProfile, Agent -ForEach $InstancesTo
 #     }
 # }
 
-# Describe "Valid Job Owner" -Tags ValidJobOwner, $filename {
-#     [string[]]$targetowner = Get-DbcConfigValue agent.validjobowner.name
-
-#     if ($NotContactable -contains $psitem) {
-#         Context "Testing job owners on $psitem" {
-#             It "Can't Connect to $Psitem" {
-#                 $false | Should -BeTrue -Because "The instance should be available to be connected to!"
-#             }
-#         }
-#     }
-#     else {
-#         Context "Testing job owners on $psitem" {
-#             @(Get-DbaAgentJob -SqlInstance $psitem -EnableException:$false).ForEach{
-#                 It "Job $($psitem.Name)  - owner $($psitem.OwnerLoginName) should be in this list ( $( [String]::Join(", ", $targetowner) ) ) on $($psitem.SqlInstance)" {
-#                     $psitem.OwnerLoginName | Should -BeIn $TargetOwner -Because "The account that is the job owner is not what was expected"
-#                 }
-#             }
-#         }
-#     }
-# }
 # Describe "Invalid Job Owner" -Tags InValidJobOwner, $filename {
 #     [string[]]$targetowner = Get-DbcConfigValue agent.invalidjobowner.name
 

source/internal/configurations/configuration.ps1

@@ -345,6 +345,7 @@ Set-PSFConfig -Module dbachecks -Name skip.agent.databasemailprofile -Validation
 Set-PSFConfig -Module dbachecks -Name skip.agent.mailprofile -Validation bool -Value $false -Initialize -Description "Skip the SQL Server Agent Mail Profile check"
 Set-PSFConfig -Module dbachecks -Name skip.agent.longrunningjobs -Validation bool -Value $false -Initialize -Description "Skip the long running agent jobs check"
 Set-PSFConfig -Module dbachecks -Name skip.agent.lastjobruntime -Validation bool -Value $false -Initialize -Description "Skip the last agent job time check"
+Set-PSFConfig -Module dbachecks -Name skip.agent.jobowner -Validation bool -Value $false -Initialize -Description "Skip the Agent Job Owner check"
 
 
 

source/internal/functions/Get-AllAgentInfo.ps1

@@ -32,9 +32,12 @@ function Get-AllAgentInfo {
     # JobServer Initial fields
     $AgentMailProfileInitFields = $Instance.GetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Agent.JobServer])
 
-
+    # Database Mail Profile Initial fields
     $DatabaseMailProfileInitFields = $Instance.GetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Mail.MailProfile])
 
+    # JobOwner Initial fields
+    $JobOwnerInitFields = $Instance.GetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Agent.Job])
+
     # Database Initial Fields
     $DatabaseInitFields = $Instance.GetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Database])
 
@@ -160,6 +163,7 @@ function Get-AllAgentInfo {
             $ConfigValues | Add-Member -MemberType NoteProperty -Name 'AgentMailProfile' -Value (Get-DbcConfigValue agent.databasemailprofile)
 
             $agentMailProfile = $ConfigValues.AgentMailProfile.ForEach{
+
                 [PSCustomObject]@{
                     InstanceName             = $Instance.Name
                     ExpectedAgentMailProfile = $ConfigValues.AgentMailProfile
@@ -185,7 +189,21 @@ function Get-AllAgentInfo {
 
         }
         'ValidJobOwner' {
+            $JobOwnerInitFields.Add("OwnerLoginName") | Out-Null # so we can check Job Owner
+            $JobOwnerInitFields.Add("Name") | Out-Null # so we can check Job Name
+            $Instance.SetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Agent.Job], $JobOwnerInitFields)
+            $JobOwnerInitFields = $Instance.GetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Agent.Job])
+
+            $ConfigValues | Add-Member -MemberType NoteProperty -Name 'TargetJobOwner' -Value (Get-DbcConfigValue agent.validjobowner.name)
 
+            $JobOwner = $Instance.JobServer.Jobs.ForEach{
+                [PSCustomObject]@{
+                    InstanceName          = $Instance.Name
+                    JobName               = $PSItem.Name
+                    ExpectedJobOwnerName  = $ConfigValues.TargetJobOwner #$PSItem
+                    ActualJobOwnerName    = $PSItem.OwnerLoginName
+                }
+            }
         }
         'InValidJobOwner' {
 
@@ -219,6 +237,7 @@ function Get-AllAgentInfo {
         FailSafeOperator    = @($failsafeOperator)
         DatabaseMailProfile = @($databaseMailProfile)
         AgentMailProfile    = @($agentMailProfile)
+        JobOwner            = $JobOwner
     }
     return $testInstanceObject
 }