Merge branch 'instancecheckscontinued' of https://github.com/dataplat/dbachecks into instancecheckscontinued

Author: jpomfret

.vscode/settings.json

@@ -7,6 +7,7 @@
         "count",
         "cpu",
         "datafile",
+        "dbachecks",
         "dbcconfig",
         "djfcc",
         "dstrait",
@@ -51,4 +52,4 @@
     "cSpell.enableFiletypes": [
         "powershell"
     ]
-}
+}

containers/JessAndBeard.psm1

@@ -2312,7 +2312,7 @@ Uh-Oh - The Tag filters between v4 and v5 are not the same somehow.
 For v4 We returned
 {0}
 and
-For v5 we returned
+for v4 we returned
 {1}
 " -f ($v4code.TagFilter | Out-String), ($v5code.Configuration.Filter.Tag.Value | Out-String)
       Write-PSFMessage -Message $Message -Level Warning
@@ -2325,47 +2325,54 @@ The Tags are the same"
   $changedTags = @(
       @{
           Name          = 'TraceFlagsExpected'
-          RunChange     = 3 # + or - the number of tests run for v5
-          PassedChange  = 3 # + or - the number of tests passed for v5
-          FailedChange  = 0 # + or - the number of tests failed for v5
-          SkippedChange = 0 # + or - the number of tests skipped for v5
+          RunChange     = 3 # + or - the number of tests run for v4
+          PassedChange  = 3 # + or - the number of tests passed for v4
+          FailedChange  = 0 # + or - the number of tests failed for v4
+          SkippedChange = 0 # + or - the number of tests skipped for v4
 
       },
       @{
           Name          = 'TraceFlagsNotExpected'
-          RunChange     = 3 # + or - the number of tests for v5
-          PassedChange  = 3 # + or - the number of tests passed for v5
-          FailedChange  = 0 # + or - the number of tests failed for v5
-          SkippedChange = 0 # + or - the number of tests skipped for v5
+          RunChange     = 3 # + or - the number of tests for v4
+          PassedChange  = 3 # + or - the number of tests passed for v4
+          FailedChange  = 0 # + or - the number of tests failed for v4
+          SkippedChange = 0 # + or - the number of tests skipped for v4
       },
       @{
           Name          = 'XESessionRunningAllowed'
-          RunChange     = -12 # + or - the number of tests for v5
-          PassedChange  = 0 # + or - the number of tests passed for v5
-          FailedChange  = -12 # + or - the number of tests failed for v5
-          SkippedChange = 0 # + or - the number of tests skipped for v5
+          RunChange     = -12 # + or - the number of tests for v4
+          PassedChange  = 0 # + or - the number of tests passed for v4
+          FailedChange  = -12 # + or - the number of tests failed for v4
+          SkippedChange = 0 # + or - the number of tests skipped for v4
       },
       @{
           Name          = 'LinkedServerConnection'
-          RunChange     = -3 # + or - the number of tests for v5
-          PassedChange  = -3 # + or - the number of tests passed for v5
-          FailedChange  = 0 # + or - the number of tests failed for v5
-          SkippedChange = 0 # + or - the number of tests skipped for v5
+          RunChange     = -3 # + or - the number of tests for v4
+          PassedChange  = -3 # + or - the number of tests passed for v4
+          FailedChange  = 0 # + or - the number of tests failed for v4
+          SkippedChange = 0 # + or - the number of tests skipped for v4
       },
       @{
           Name          = 'SupportedBuild'
-          RunChange     = -3 # + or - the number of tests run for v5
-          PassedChange  = -3 # + or - the number of tests passed for v5
-          FailedChange  = 0 # + or - the number of tests failed for v5
-          SkippedChange = 0 # + or - the number of tests skipped for v5
+          RunChange     = -3 # + or - the number of tests run for v4
+          PassedChange  = -3 # + or - the number of tests passed for v4
+          FailedChange  = 0 # + or - the number of tests failed for v4
+          SkippedChange = 0 # + or - the number of tests skipped for v4
       },
       @{
           Name          = 'GuestUserConnect'
-          RunChange     = 0 # + or - the number of tests run for v5
-          PassedChange  = +2 # + or - the number of tests passed for v5
-          FailedChange  = -2 # + or - the number of tests failed for v5
-          SkippedChange = 0 # + or - the number of tests skipped for v5
+          RunChange     = 0 # + or - the number of tests run for v4
+          PassedChange  = +2 # + or - the number of tests passed for v4
+          FailedChange  = -2 # + or - the number of tests failed for v4
+          SkippedChange = 0 # + or - the number of tests skipped for v4
       },
+      @{
+          Name          = 'AgentServiceAccount'
+          RunChange     = -3 # + or - the number of tests run for v4
+          PassedChange  = -5 # + or - the number of tests passed for v4
+          FailedChange  = -1 # + or - the number of tests failed for v4
+          SkippedChange = +3 # + or - the number of tests skipped for v4
+          },
       @{
           Name          = 'SqlEngineServiceAccount'
           RunChange     = -3 # + or - the number of tests run for v5
@@ -2407,7 +2414,7 @@ Uh-Oh - The total tests run between v4 and v5 are not the same somehow.
 For v4 We ran
 {0} tests
 and
-For v5 we ran
+for v4 we ran
 {1} tests
 The MOST COMMON REASON IS you have used Tags instead of Tag in your Describe block {2}
 " -f $v4code.TotalCount, $v5run, $messageAppend
@@ -2427,7 +2434,7 @@ Uh-Oh - The total tests Passed between v4 and v5 are not the same somehow.
 For v4 We Passed
 {0} tests
 and
-For v5 we Passed
+for v4 we Passed
 {1} tests
 {2}
 
@@ -2454,7 +2461,7 @@ Uh-Oh - The total tests Failed between v4 and v5 are not the same somehow.
 For v4 We Failed
 {0} tests
 and
-For v5 we Failed
+for v4 we Failed
 {1} tests
 
 " -f $v4code.FailedCount, $v5Failed, $messageAppend