Implemented extra checks. Fixes #7. Fixes #8

Author: sanderstad

functions/image/New-PSDCImage.ps1

@@ -112,8 +112,6 @@
         $DestinationCredential,
         [System.Management.Automation.PSCredential]
         $PSDCSqlCredential,
-        [Parameter(Mandatory = $true)]
-        [ValidateNotNullOrEmpty()]
         [string]$ImageNetworkPath,
         [string]$ImageLocalPath,
         [Parameter(Mandatory = $true, ValueFromPipeline = $true)]
@@ -131,6 +129,12 @@
             return
         }
 
+        # Checking parameters
+        if (-not $ImageNetworkPath) {
+            Stop-PSFFunction -Message "Please enter the network path where to save the images"
+            return
+        }
+
         # Get the information store
         $informationStore = Get-PSFConfigValue -FullName psdatabaseclone.informationstore.mode
 
@@ -207,12 +211,6 @@
             }
         }
 
-        # Check if Hyper-V is enabled
-        if (-not (Test-PSDCHyperVEnabled -HostName $uriHost -Credential $DestinationCredential)) {
-            Stop-PSFFunction -Message "Hyper-V is not enabled on the host." -ErrorRecord $_ -Target $uriHost
-            return
-        }
-
         # Get the local path from the network path
         if (-not $ImageLocalPath) {
             if ($PSCmdlet.ShouldProcess($ImageNetworkPath, "Converting UNC path to local path")) {
@@ -232,13 +230,46 @@
                     }
 
                     Write-PSFMessage -Message "Converted '$ImageNetworkPath' to '$ImageLocalPath'" -Level Verbose
+
                 }
                 catch {
                     Stop-PSFFunction -Message "Something went wrong getting the local image path" -Target $ImageNetworkPath
                     return
                 }
             }
         }
+        else {
+            # Cleanup the values in the network path
+            if ($ImageLocalPath.EndsWith("\")) {
+                $ImageLocalPath = $ImageLocalPath.Substring(0, $ImageLocalPath.Length - 1)
+            }
+
+            # Check if the assigned value in the local path corresponds to the one retrieved
+            try {
+                # Check if computer is local
+                if ($computer.IsLocalhost) {
+                    $convertedLocalPath = Convert-PSDCLocalUncPathToLocalPath -UncPath $ImageNetworkPath -EnableException
+                }
+                else {
+                    $command = "Convert-PSDCLocalUncPathToLocalPath -UncPath `"$ImageNetworkPath`" -EnableException"
+                    $commandGetLocalPath = [ScriptBlock]::Create($command)
+                    $convertedLocalPath = Invoke-PSFCommand -ComputerName $computer -ScriptBlock $commandGetLocalPath -Credential $DestinationCredential
+                }
+
+                Write-PSFMessage -Message "Converted '$ImageNetworkPath' to '$ImageLocalPath'" -Level Verbose
+
+                # Check if the ImageLocalPath and convertedLocalPath are the same
+                if ($ImageLocalPath -ne $convertedLocalPath) {
+                    Stop-PSFFunction -Message "The local path '$ImageLocalPath' is not the same location as the network path '$ImageNetworkPath'" -Target $ImageNetworkPath
+                    return
+                }
+
+            }
+            catch {
+                Stop-PSFFunction -Message "Something went wrong getting the local image path" -Target $ImageNetworkPath
+                return
+            }
+        }
 
         # Check the image local path
         if ($PSCmdlet.ShouldProcess("Verifying image local path")) {
@@ -269,6 +300,12 @@
             Stop-PSFFunction -Message "Please supply a database to create an image for" -Target $SourceSqlInstance -Continue
         }
 
+        # Check if Hyper-V is enabled
+        if (-not (Test-PSDCHyperVEnabled -HostName $uriHost -Credential $DestinationCredential)) {
+            Stop-PSFFunction -Message "Hyper-V is not enabled on the host." -ErrorRecord $_ -Target $uriHost
+            return
+        }
+
         # Set time stamp
         $timestamp = Get-Date -format "yyyyMMddHHmmss"
 
@@ -543,10 +580,10 @@
                 [array]$images = $null
 
                 # Get all the images
-                try{
+                try {
                     $images = Get-PSDCImage
                 }
-                catch{
+                catch {
                     Stop-PSFFunction -Message "Couldn't get images" -Target $imageName -ErrorRecord $_
                     return
                 }