Generalize assembly loading logic for known DLLs

Replaces special handling for System.Management.Automation with a generalized approach for all known DLLs. Now, if an assembly with the same name is already loaded, it is returned and a warning is logged if the requested version differs from the loaded version.

Author: potatoqualitee

dbatools.library.psm1

@@ -63,25 +63,20 @@ if ($PSVersionTable.PSEdition -ne "Core") {
                     {
                         if (assemblyName == dll)
                         {
-                            // Special handling for System.Management.Automation:
-                            // Always return the already loaded assembly, regardless of requested version.
-                            if (assemblyName == "System.Management.Automation")
+                            // Generalized handling for all known DLLs:
+                            // If an assembly with the same name is already loaded, return it (warn if version differs).
+                            var loaded = AppDomain.CurrentDomain.GetAssemblies()
+                                .FirstOrDefault(a => a.GetName().Name == assemblyName);
+                            if (loaded != null)
                             {
-                                var loaded = AppDomain.CurrentDomain.GetAssemblies()
-                                    .FirstOrDefault(a => a.GetName().Name == "System.Management.Automation");
-                                if (loaded != null)
+                                var requestedVersion = name.Version;
+                                var loadedVersion = loaded.GetName().Version;
+                                if (requestedVersion != null && loadedVersion != null && requestedVersion != loadedVersion)
                                 {
-                                    var requestedVersion = name.Version;
-                                    var loadedVersion = loaded.GetName().Version;
-                                    if (requestedVersion != null && loadedVersion != null && requestedVersion != loadedVersion)
-                                    {
-                                        // Log a warning if the requested version does not match the loaded version.
-                                        System.Diagnostics.Trace.TraceWarning(
-                                            $"[dbatools] Requested System.Management.Automation version {requestedVersion}, but loaded version is {loadedVersion}. Using loaded version.");
-                                    }
-                                    return loaded;
+                                    System.Diagnostics.Trace.TraceWarning(
+                                        $"[dbatools] Requested {assemblyName} version {requestedVersion}, but loaded version is {loadedVersion}. Using loaded version. This may cause compatibility issues if APIs differ.");
                                 }
-                                // If not found, fall through to normal logic (should not happen in PowerShell host)
+                                return loaded;
                             }
                             string filelocation = "$dir" + dll + ".dll";
                             //Console.WriteLine(filelocation);