Skip to content

Commit 7610293

Browse files
Refactor package references by target framework
Hopefully this continues to work on PSv3 Moved System.Threading.Tasks.Dataflow and Microsoft.PowerShell.SDK package references to framework-specific ItemGroups for net472 and net8.0. This allows for correct versioning and dependency management per target framework.
1 parent 9e8a3aa commit 7610293

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

project/dbatools/dbatools.csproj

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,20 +51,24 @@
5151
<LangVersion>7.3</LangVersion>
5252
</PropertyGroup>
5353

54+
<!-- Shared packages for both frameworks -->
5455
<ItemGroup>
5556
<PackageReference Include="Microsoft.AnalysisServices" Version="19.101.1" />
5657
<PackageReference Include="Microsoft.Data.SqlClient" Version="6.0.2" />
5758
<PackageReference Include="Microsoft.SqlServer.DacFx" Version="170.0.94" />
5859
<PackageReference Include="Microsoft.SqlServer.SqlManagementObjects" Version="172.76.0" />
5960
<PackageReference Include="Microsoft.SqlServer.XEvent.XELite" Version="2024.2.5.1" />
60-
<PackageReference Include="System.Threading.Tasks.Dataflow" Version="9.0.7" />
6161
</ItemGroup>
6262

63-
<ItemGroup>
64-
<PackageReference Include="Microsoft.PowerShell.SDK" Version="7.4.0" PrivateAssets="all" />
63+
<!-- Framework-specific packages -->
64+
<ItemGroup Condition="'$(TargetFramework)' == 'net472'">
65+
<PackageReference Include="System.Threading.Tasks.Dataflow" Version="6.0.0" />
66+
<PackageReference Include="Microsoft.Management.Infrastructure" Version="3.0.0" />
6567
</ItemGroup>
6668

67-
<ItemGroup Condition="'$(TargetFramework)' == 'net472'">
69+
<ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
70+
<PackageReference Include="System.Threading.Tasks.Dataflow" Version="8.0.1" />
71+
<PackageReference Include="Microsoft.PowerShell.SDK" Version="7.4.0" PrivateAssets="all" />
6872
<PackageReference Include="Microsoft.Management.Infrastructure" Version="3.0.0" />
6973
</ItemGroup>
7074

@@ -77,7 +81,7 @@
7781
</Reference>
7882
</ItemGroup>
7983

80-
<!-- Linux/non-Windows PowerShell SDK reference for net472 -->
84+
<!-- Linux/non-Windows PowerShell reference for net472 -->
8185
<ItemGroup Condition="'$(TargetFramework)' == 'net472' AND '$(OS)' != 'Windows_NT'">
8286
<PackageReference Include="PowerShellStandard.Library" Version="5.1.1" />
8387
</ItemGroup>

0 commit comments

Comments
 (0)