Major update to v2025.7.19 - .NET 8 migration, improved assembly loading, and cross-platform enhancements (#18)

* Update .gitignore with new exclusions

Removed docker-compose.yml from ignored files and added exclusions for OLDLIB, .devcontainer/.env, dbatools.library.zip, /artifacts, and .roo/mcp.json to better manage project artifacts and environment files.

* Add devcontainer setup and AI

Introduces .devcontainer configuration for development environments, including Dockerfile, docker-compose, environment example, PowerShell setup scripts, and workspace settings. Adds project metadata files such as .mcp.json, .claude/settings.local.json, .vscode.code-workspace, and CLAUDE.md for guidance and context. These changes enable standardized development, testing, and module management workflows.

* Add preview release workflow and update build process

Introduces a new build-release.yml workflow for building and publishing preview releases, including multi-platform build, artifact upload, and release creation. Updates build.yml to improve build steps, artifact handling, and verification, and switches to workflow_dispatch trigger for manual builds.

* Refactor build scripts and add MSI install helper

Replaces build-core.ps1, build-full.ps1, and build-local.ps1 with a unified build.ps1 script that centralizes build logic, artifact management, and dependency handling. Adds Wait-MsiInstall.ps1 to provide robust MSI installation waiting and error handling. This refactor streamlines the build process, improves maintainability, and ensures safer MSI package operations.

* Update target frameworks and add publish profile

Upgraded test project to target net472 and net8.0, updated global.json to use .NET SDK 8.0.*, and added a folder publish profile for dbatools. These changes modernize the project and enable publishing to a local folder.

* Add DbaRenewableToken wrapper class

Introduces DbaRenewableToken, a thin wrapper around IRenewableToken to facilitate token usage in Connect-DbaInstance. Supports construction from various token sources including SqlAuthenticationToken and PSObject.

* Update target frameworks and package dependencies

Upgraded target frameworks from net462/net6.0 to net472/net8.0. Updated and replaced several NuGet package references to newer versions, added Microsoft.AnalysisServices and System.Runtime.CompilerServices.Unsafe, and removed obsolete configuration blocks for ps3/ps4. Adjusted output paths and language version settings for improved compatibility and build output.

* Update project configuration and dependencies (Claude minimal changes)

Moved OutputPath, DocumentationFile, and LangVersion properties into configuration-specific PropertyGroups. Added new PropertyGroups for 'ps3' and 'ps4' configurations. Replaced System.Runtime.CompilerServices.Unsafe with System.Threading.Tasks.Dataflow in package references.

* Update SQL Server and AnalysisServices DLLs

Added new SQL Server related DLLs and updated several existing ones. Removed multiple Microsoft.AnalysisServices DLLs from both core and desktop directories, possibly reflecting a change in dependencies or supported features.

* Simplify SqlClient and LumenWorks import logic

Removed platform-specific win-sqlclient handling and macOS logic, as SqlClient is now directly in the lib folder. LumenWorks import is now explicit and not included in the names array. Updated Bogus import to use correct casing.

* Update default dbatools branch in build workflow

Changed the default branch for dbatools downloads from 'newver' to 'newestver' in the build-release GitHub Actions workflow.

* Azure.Core - Update assembly list for PowerShell editions

Reordered and added missing assemblies to the $names array for both Core and non-Core PowerShell editions. Ensures consistent loading of Azure and identity-related assemblies, and corrects duplication and ordering issues.

* Add Azure.Core and Azure.Identity to assembly list

Included 'Azure.Core' and 'Azure.Identity' in the list of assemblies for loading when not running on PowerShell Core. This may be required for new Azure-related functionality or dependencies.

* Bump module version to 2025.7.19

Updated the ModuleVersion in dbatools.library.psd1 to reflect the new release version.

* Refactor sqlpackage path detection in build workflow

Simplifies and unifies the logic for locating sqlpackage executables across platforms in the build-release workflow. The new approach iterates over possible paths and provides improved error reporting and directory listing for troubleshooting.

* Change sqlpackage error to warning in build workflow

Replaces Write-Error with Write-Warning when sqlpackage is not found in the build-release workflow. This provides a less severe notification while still exiting with code 1.

* Update sqlpackage not found warning in build workflow

Refines the warning message when sqlpackage is not found and changes the directory listing to output full paths instead of just names. Removes the exit statement to prevent premature job termination.

* Improve sqlpackage search in build workflow

Refines the PowerShell command to recursively search for directories matching 'sqlpack' in the module path, making the sqlpackage lookup more accurate during the build-release workflow.

* Fix sqlpackage path casing in build workflow

Corrected the filename from 'sqlpackage.exe' to 'SqlPackage.exe' in the Windows path to ensure compatibility with case-sensitive file systems.

* Update build workflow for core library artifacts

Removes redundant Windows sqlpackage from core library as it matches the desktop version. Updates critical file verification to reflect this change by removing 'core\lib\dac\windows' and adding 'desktop\lib\dac'.

* Update NuGet package versions in dbatools.csproj

Upgraded Microsoft.Data.SqlClient to 6.0.2 and System.Threading.Tasks.Dataflow to 9.0.7 to ensure compatibility with latest features and bug fixes.

* Add Microsoft.Bcl.AsyncInterfaces to DLL imports

Included 'Microsoft.Bcl.AsyncInterfaces' in the list of DLLs imported for non-Core PowerShell editions to support async interfaces and improve compatibility.

* Add System.Text.Json to required assemblies

Included System.Text.Json in the list of assemblies loaded for non-Core PowerShell editions to support features that depend on JSON serialization.

* Add Windows-specific GAC reference for net472

Introduced a conditional ItemGroup to reference System.Management.Automation from the GAC only when targeting net472 on Windows. This ensures proper assembly resolution in Windows environments.

* Add PowerShell SDK reference for non-Windows net472

Adds a conditional PackageReference to PowerShellStandard.Library for net472 targets on non-Windows platforms to improve cross-platform compatibility.

* Update sqlpackage paths in CI workflows

Adjusted PowerShell scripts in build-release.yml and sqlpackage.yml to reference new sqlpackage locations for Windows, Linux, and Mac. Ensures correct executable is used for each platform and PowerShell edition.

* Remove handling of 'private' directory from build scripts

Eliminated references to the 'private' directory in GitHub workflow files and build.ps1. The creation and copying of the 'private' directory and its contents are no longer performed, streamlining the build process and artifact packaging.

* Remove mcp.json configuration file

Deleted the .roo/mcp.json file, which contained MCP server configuration for brave-search. This cleans up unused or obsolete configuration.

* Remove sqlpackage GitHub Actions workflow

Deleted the sqlpackage.yml workflow file from .github/workflows. This removes automated testing of sqlpackage across multiple platforms on pull requests.

Author: potatoqualitee

.claude/settings.local.json

@@ -1,7 +1,6 @@
 {
-    "model": "opus",
+    "model": "sonnet",
     "cleanupPeriodDays": 30,
-    "dangerously-skip-permissions": true,
     "permissions": {
         "defaultMode": "bypassPermissions",
         "allow": ["*"],

.devcontainer/devcontainer.json

@@ -52,7 +52,9 @@
                     }
                 },
                 "terminal.integrated.shell.linux": "pwsh",
-                "terminal.integrated.defaultProfile.linux": "pwsh"
+                "terminal.integrated.defaultProfile.linux": "pwsh",
+                "powershell.developer.editorServicesLogLevel": "Error",
+                "powershell.integratedConsole.suppressStartupBanner": true
             },
             "extensions": [
                 "ms-vscode.powershell",

.devcontainer/scripts/profile.ps1

@@ -0,0 +1 @@
+$env:POWERSHELL_UPDATECHECK = 'Off'

.github/workflows/build-release.yml

@@ -21,8 +21,32 @@ on:
         required: false
 
 jobs:
+  linux-build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Setup .NET
+      uses: actions/setup-dotnet@v4
+      with:
+        dotnet-version: |
+          8.0.x
+          6.0.x
+
+    - name: Build core/lib
+      shell: pwsh
+      run: |
+        ./build/build.ps1 -CoreOnly
+
+    - name: Upload Linux artifacts
+      uses: actions/upload-artifact@v4
+      with:
+          name: core-lib-linux
+          path: artifacts/dbatools.library/core/lib/
+
   build-windows:
     runs-on: windows-latest
+    needs: linux-build
 
     steps:
     - name: Checkout code
@@ -45,7 +69,23 @@ jobs:
       shell: pwsh
       run: |
         # Run the build script
-        .\build\build.ps1
+        .\build\build.ps1 -BuildZip
+
+    - name: Download Linux artifacts
+      uses: actions/download-artifact@v4
+      with:
+        name: core-lib-linux
+        path: artifacts/core-lib-linux/
+
+    - name: Extract core-lib-linux artifact and copy to core/lib
+      shell: pwsh
+      run: Copy-Item -Path "artifacts/core-lib-linux/*" -Destination "artifacts/dbatools.library/core/lib" -Recurse -Force
+
+    - name: Ensure sqlpackage is executable
+      shell: pwsh
+      run: |
+        chmod +x ./artifacts/dbatools.library/core/lib/dac/linux/sqlpackage
+        chmod +x ./artifacts/dbatools.library/core/lib/dac/mac/sqlpackage
 
     - name: Verify critical files and directories
       shell: pwsh
@@ -56,14 +96,13 @@ jobs:
         $criticalPaths = @(
           "desktop\lib",
           "desktop\lib\runtimes\win-x64\native",
+          "core\lib\dac\windows",
           "desktop\third-party",
           "core\lib",
           "core\lib\runtimes\win-x64\native",
-          "core\lib\dac\windows",
           "core\lib\dac\linux",
           "core\lib\dac\mac",
-          "core\third-party",
-          "private"
+          "core\third-party"
         )
 
         $missingPaths = @()
@@ -110,7 +149,7 @@ jobs:
         path: artifacts/dbatools.library.zip
 
   test-sqlpackage:
-    name: Test SqlPackage on ${{ matrix.os }}
+    name: Test sqlpackage on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     needs: build-windows
     strategy:
@@ -144,7 +183,7 @@ jobs:
           exit 1
         }
 
-    - name: Test SqlPackage
+    - name: Test sqlpackage
       shell: pwsh
       run: |
         # Import the built module
@@ -158,71 +197,68 @@ jobs:
         Write-Host "Module loaded successfully with version: $($module.Version)"
         Write-Host "Module path: $($module.ModuleBase)"
 
-        # Determine SqlPackage path based on OS
+        # Determine sqlpackage path based on OS
         $modulePath = $module.ModuleBase
-        if ($IsWindows -or $PSVersionTable.PSVersion.Major -eq 5) {
-            Write-Host "Testing Windows SqlPackage..."
-            $dacPath = Join-Path $modulePath "core/lib/dac/windows"
-            $sqlPackageName = "SqlPackage.exe"
-        } elseif ($IsLinux) {
-            Write-Host "Testing Linux SqlPackage..."
-            $dacPath = Join-Path $modulePath "core/lib/dac/linux"
-            $sqlPackageName = "SqlPackage"
-        } elseif ($IsMacOS) {
-            Write-Host "Testing macOS SqlPackage..."
-            $dacPath = Join-Path $modulePath "core/lib/dac/mac"
-            $sqlPackageName = "SqlPackage"
-        } else {
-            Write-Error "Unknown operating system"
-            exit 1
-        }
+        $sqlPackageName = @(
+          (Join-Path $modulePath "desktop/lib/dac/SqlPackage.exe"),
+          (Join-Path $modulePath "core/lib/dac/windows/sqlpackage.exe"),
+          (Join-Path $modulePath "core/lib/dac/linux/sqlpackage"),
+          (Join-Path $modulePath "core/lib/dac/mac/sqlpackage")
+        )
 
-        # Check if SqlPackage directory exists
-        if (-not (Test-Path $dacPath)) {
-            Write-Error "SqlPackage directory not found: $dacPath"
-            Write-Host "Available directories in core/lib:"
-            Get-ChildItem (Join-Path $modulePath "core/lib") -Directory | ForEach-Object { Write-Host "  - $($_.Name)" }
-            exit 1
+        foreach ($sqlPackage in $sqlPackageName) {
+          if (Test-Path $sqlPackage) {
+            Write-Host "Found sqlpackage at: $sqlPackage"
+          } else {
+            Write-Warning "sqlpackage not found: $sqlPackage"
+            Write-Host "Available directories in module"
+            Get-ChildItem $modulePath -Recurse | Where-Object Name -match sqlpack | Select-Object Fullname
+          }
         }
 
-        # Check if SqlPackage executable exists
-        $sqlPackagePath = Join-Path $dacPath $sqlPackageName
-        if (-not (Test-Path $sqlPackagePath)) {
-            Write-Error "SqlPackage executable not found: $sqlPackagePath"
-            Write-Host "Files in $dacPath :"
-            Get-ChildItem $dacPath | ForEach-Object { Write-Host "  - $($_.Name)" }
-            exit 1
+        $sqlPackagePath = if ($IsMacOS) {
+          Join-Path $modulePath "core/lib/dac/mac/sqlpackage"
+        } elseif ($IsLinux) {
+          Join-Path $modulePath "core/lib/dac/linux/sqlpackage"
+        } else {
+          # if core then core
+          if ($PSVersionTable.PSEdition -eq 'Core') {
+            Join-Path $modulePath "core/lib/dac/windows/sqlpackage.exe"
+          } else {
+            # if desktop then desktop
+            Join-Path $modulePath "desktop/lib/dac/SqlPackage.exe"
+          }
         }
 
-        Write-Host "SqlPackage found at: $sqlPackagePath"
+        Write-Host "Using sqlpackage at: $sqlPackagePath"
 
-        # Make SqlPackage executable on non-Windows platforms
+        # Make sqlpackage executable on non-Windows platforms
         if ($IsLinux -or $IsMacOS) {
             chmod +x $sqlPackagePath
         }
 
-        # Test SqlPackage execution
+        # Test sqlpackage execution
         try {
-            Write-Host "Testing SqlPackage execution..."
+            Write-Host "Testing sqlpackage execution..."
             $versionOutput = & $sqlPackagePath /Version 2>&1
-            Write-Host "SqlPackage version: $versionOutput"
+            Write-Host "sqlpackage version: $versionOutput"
 
             # Basic functionality test - show help
-            Write-Host "`nTesting SqlPackage help command..."
+            Write-Host "`nTesting sqlpackage help command..."
             $helpOutput = & $sqlPackagePath /? 2>&1 | Select-Object -First 10
             $helpOutput | ForEach-Object { Write-Host $_ }
             Write-Host "... (output truncated)"
 
             # Verify expected output from help
             $helpString = $helpOutput -join "`n"
-            if ($helpString -match "Specifies a name value pair" -or $helpString -match "SqlPackage" -or $helpString -match "Command") {
-                Write-Host "`nSqlPackage test completed successfully!"
+            if ($helpString -match "Specifies a name value pair" -or $helpString -match "sqlpackage" -or $helpString -match "Command") {
+                Write-Host "`nsqlpackage test completed successfully!"
             } else {
-                Write-Error "SqlPackage help output does not contain expected content"
+                Write-Error "sqlpackage help output does not contain expected content"
                 exit 1
             }
         } catch {
-            Write-Error "Failed to execute SqlPackage: $_"
+            Write-Error "Failed to execute sqlpackage: $_"
             exit 1
         }
 
@@ -252,7 +288,7 @@ jobs:
         }
 
         # Download dbatools from GitHub
-        $branch = "${{ github.event.inputs.dbatools_branch || 'newver' }}"
+        $branch = "${{ github.event.inputs.dbatools_branch || 'newestver' }}"
         Write-Host "Downloading dbatools from GitHub (branch: $branch)..."
 
         $zipUrl = "https://github.com/dataplat/dbatools/archive/refs/heads/$branch.zip"
@@ -309,17 +345,20 @@ jobs:
         Write-Host "Importing dbatools..."
         Import-Module dbatools -Force
 
-        Write-Host "Testing Get-DbaManagementObject..."
+        Write-Host "Testing Connect-DbaInstance..."
         try {
-            $result = Get-DbaManagementObject
-            Write-Host "Test passed: Get-DbaManagementObject ran without fail"
+            $result = Connect-DbaInstance -SqlInstance localhost
         } catch {
-            Write-Error "Test failed with exception: $_"
-            exit 1
+            if ($PSItem.Exception.Message -notmatch "not accessible") {
+              Write-Error "Test failed with exception: $_"
+              exit 1
+            } else {
+              Write-Host "Test failed successfully (lol) with inaccessible instance message: $($PSItem.Exception.Message)" -ForegroundColor Green
+            }
         }
 
   create-preview-release:
-    needs: [build-windows, test-sqlpackage]
+    needs: [linux-build, build-windows, test-sqlpackage]
     runs-on: windows-latest
     # Create release if manually triggered OR if version contains "preview"
     if: github.event_name == 'workflow_dispatch' || github.event_name == 'push'

.github/workflows/build.yml

@@ -5,14 +5,42 @@ defaults:
   run:
     shell: pwsh
 jobs:
-  # Linux tests are disabled - build-core.ps1 script not found
-  # Keeping Windows build test only for now
+  linux-build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Setup .NET
+      uses: actions/setup-dotnet@v4
+      with:
+        dotnet-version: |
+          8.0.x
+          6.0.x
+
+    - name: Build core/lib
+      shell: pwsh
+      run: |
+        ./build/build.ps1 -CoreOnly
+
+    - name: Upload Linux artifacts
+      uses: actions/upload-artifact@v4
+      with:
+        name: core-lib-linux
+        path: artifacts/dbatools.library/core/lib/
+
   windows-tests:
     runs-on: windows-latest
+    needs: linux-build
 
     steps:
     - uses: actions/checkout@v4
 
+    - name: Download Linux artifacts
+      uses: actions/download-artifact@v4
+      with:
+        name: core-lib-linux
+        path: artifacts/dbatools.library/core/lib/
+
     - name: Setup .NET
       uses: actions/setup-dotnet@v4
       with:
@@ -31,6 +59,13 @@ jobs:
       run: |
         ./build/build.ps1
 
+    - name: Copy Linux core/lib files
+      shell: pwsh
+      run: |
+        Copy-Item -Path artifacts/core-lib-linux/* -Destination artifacts/dbatools.library/core/lib/ -Recurse -Force
+        # delete windows sqlpackage on core cuz its the same as desktop
+        Remove-Item -Path artifacts/dbatools.library/core/lib/dac/windows -Recurse -Force -ErrorAction Ignore
+
     - name: Verify critical files and directories
       shell: pwsh
       run: |
@@ -39,15 +74,14 @@ jobs:
         $artifactsDir = "./artifacts/dbatools.library"
         $criticalPaths = @(
           "desktop\lib",
+          "desktop\lib\dac",
           "desktop\lib\runtimes\win-x64\native",
           "desktop\third-party",
           "core\lib",
           "core\lib\runtimes\win-x64\native",
-          "core\lib\dac\windows",
           "core\lib\dac\linux",
           "core\lib\dac\mac",
-          "core\third-party",
-          "private"
+          "core\third-party"
         )
 
         $missingPaths = @()

.gitignore

@@ -40,3 +40,4 @@ lib/
 .devcontainer/.env
 dbatools.library.zip
 /artifacts
+.roo/mcp.json

.roo/mcp.json

@@ -91,7 +91,7 @@ Get-DbatoolsLoadedAssembly
 1. **Clean**: Removes previous build artifacts
 2. **Compile**: Builds C# projects for both target frameworks
 3. **Package Dependencies**: Downloads and extracts:
-   - SQL Server DacFramework (SqlPackage)
+   - SQL Server DacFramework (sqlpackage)
    - Third-party NuGet packages (Bogus, LumenWorks CSV)
    - XESmartTarget for Extended Events
 4. **Platform Distribution**: Copies assemblies to appropriate platform directories
@@ -159,17 +159,20 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 ## Development Commands
 
 ### Testing
+
+> **Note:** The following test commands reference Appveyor and Windows PowerShell scripts. For modern Linux/macOS/PowerShell Core setups or non-Appveyor CI, substitute with appropriate Pester/Invoke-Pester commands, and paths using forward slashes as needed.
+
 ```powershell
-# Run all tests
+# Run all tests (legacy, Windows/Appveyor)
 .\tests\appveyor.pester.ps1
 
-# Run tests with code coverage
+# Run tests with code coverage (Windows/Appveyor)
 .\tests\appveyor.pester.ps1 -IncludeCoverage
 
-# Run specific test file
+# Run specific test file (cross-platform)
 Invoke-Pester ./tests/Get-DbaDatabase.Tests.ps1
 
-# Finalize test results
+# Finalize test results (Windows/Appveyor)
 .\tests\appveyor.pester.ps1 -Finalize
 ```