Fix SSIS Connection Logic (#9743)

Author: potatoqualitee

public/Get-DbaSsisEnvironmentVariable.ps1

@@ -133,10 +133,7 @@ function Get-DbaSsisEnvironmentVariable {
             }
 
             try {
-                $legacyconnstring = $server | New-DbaConnectionString -Legacy
-                $sqlconnection = New-Object System.Data.SqlClient.SqlConnection $legacyconnstring
-                $null = $sqlconnection.Open()
-                $ssis = New-Object Microsoft.SqlServer.Management.IntegrationServices.IntegrationServices $sqlconnection
+                $ssis = New-Object Microsoft.SqlServer.Management.IntegrationServices.IntegrationServices $server
             } catch {
                 Stop-Function -Message "Can't load server" -Target $instance -ErrorRecord $_
                 return

public/New-DbaSsisCatalog.ps1

@@ -128,10 +128,7 @@ function New-DbaSsisCatalog {
             }
 
             try {
-                $legacyconnstring = $server | New-DbaConnectionString -Legacy
-                $sqlconnection = New-Object System.Data.SqlClient.SqlConnection $legacyconnstring
-                $null = $sqlconnection.Open()
-                $ssis = New-Object Microsoft.SqlServer.Management.IntegrationServices.IntegrationServices $sqlconnection
+                $ssis = New-Object Microsoft.SqlServer.Management.IntegrationServices.IntegrationServices $server
             } catch {
                 Stop-Function -Message "Can't load server" -Target $instance -ErrorRecord $_
                 return

tests/Get-DbaSsisEnvironmentVariable.Tests.ps1

@@ -12,6 +12,46 @@ Describe "$CommandName Unit Tests" -Tag 'UnitTests' {
         }
     }
 }
+
+<#
+
+-- Create a folder if it doesn't exist
+IF NOT EXISTS (SELECT 1 FROM [SSISDB].[catalog].[folders] WHERE name = N'TestFolder')
+BEGIN
+    EXEC [SSISDB].[catalog].[create_folder] @folder_name = N'TestFolder', @folder_id = NULL;
+END
+
+-- Create an environment in the folder if it doesn't exist
+IF NOT EXISTS (
+    SELECT 1 FROM [SSISDB].[catalog].[environments]
+    WHERE name = N'TestEnv' AND folder_id = (SELECT folder_id FROM [SSISDB].[catalog].[folders] WHERE name = N'TestFolder')
+)
+BEGIN
+    EXEC [SSISDB].[catalog].[create_environment] @folder_name = N'TestFolder', @environment_name = N'TestEnv';
+END
+
+-- Create an environment variable in the environment if it doesn't exist
+IF NOT EXISTS (
+    SELECT 1 FROM [SSISDB].[catalog].[environment_variables]
+    WHERE name = N'TestVar'
+      AND environment_id = (
+            SELECT environment_id
+            FROM [SSISDB].[catalog].[environments]
+            WHERE name = N'TestEnv'
+              AND folder_id = (SELECT folder_id FROM [SSISDB].[catalog].[folders] WHERE name = N'TestFolder')
+      )
+)
+BEGIN
+    EXEC [SSISDB].[catalog].[create_environment_variable]
+        @folder_name = N'TestFolder',
+        @environment_name = N'TestEnv',
+        @variable_name = N'TestVar',
+        @data_type = N'String',
+        @sensitive = 0,
+        @value = N'Chello';
+END
+
+#>
 <#
     Integration test should appear below and are custom to the command you are writing.
     Read https://github.com/sqlcollaborative/dbatools/blob/development/contributing.md#tests