Get-DbaAgentJob, Remove-DbaAgentJob - Add validation for null/empty Job parameter (#9931)

Author: potatoqualitee

public/Get-DbaAgentJob.ps1

@@ -140,6 +140,22 @@ function Get-DbaAgentJob {
                 $jobExecutionResults = $server.Query($query)
             }
 
+            # Check if Job parameter is bound with null, empty, or whitespace-only values
+            if (Test-Bound 'Job') {
+                if ($null -eq $Job -or $Job.Count -eq 0 -or ($Job | Where-Object { [string]::IsNullOrWhiteSpace($_) })) {
+                    Write-Message -Level Verbose -Message "The -Job parameter was explicitly provided but contains null, empty, or whitespace-only values. This may indicate an uninitialized variable. Skipping instance."
+                    continue
+                }
+            }
+
+            # Check if ExcludeJob parameter is bound with null, empty, or whitespace-only values
+            if (Test-Bound 'ExcludeJob') {
+                if ($null -eq $ExcludeJob -or $ExcludeJob.Count -eq 0 -or ($ExcludeJob | Where-Object { [string]::IsNullOrWhiteSpace($_) })) {
+                    Write-Message -Level Verbose -Message "The -ExcludeJob parameter was explicitly provided but contains null, empty, or whitespace-only values. This may indicate an uninitialized variable. Parameter will be ignored."
+                    $ExcludeJob = $null
+                }
+            }
+
             $jobs = $server.JobServer.Jobs | Where-Object JobType -in $Type
 
             if ($Job) {

public/Remove-DbaAgentJob.ps1

@@ -87,6 +87,14 @@ function Remove-DbaAgentJob {
         [switch]$EnableException
     )
     process {
+        # Check if Job parameter is bound with null, empty, or whitespace-only values
+        if (Test-Bound 'Job') {
+            if ($null -eq $Job -or $Job.Count -eq 0 -or ($Job | Where-Object { [string]::IsNullOrWhiteSpace($_) })) {
+                Write-Message -Level Verbose -Message "The -Job parameter was explicitly provided but contains null, empty, or whitespace-only values. This may indicate an uninitialized variable. Skipping operation."
+                return
+            }
+        }
+
         foreach ($instance in $SqlInstance) {
             try {
                 $server = Connect-DbaInstance -SqlInstance $instance -SqlCredential $SqlCredential

tests/Get-DbaAgentJob.Tests.ps1

@@ -133,4 +133,27 @@ Describe $CommandName -Tag IntegrationTests {
             $resultMultipleDatabases.Name -contains $jobName2 | Should -BeTrue
         }
     }
+    Context "Command validates null/empty Job parameter" {
+        It "Should return no jobs when -Job is null" {
+            $nullVariable = $null
+            $results = Get-DbaAgentJob -SqlInstance $TestConfig.instance2 -Job $nullVariable
+            $results | Should -BeNullOrEmpty
+        }
+
+        It "Should return no jobs when -Job is empty string" {
+            $results = Get-DbaAgentJob -SqlInstance $TestConfig.instance2 -Job ""
+            $results | Should -BeNullOrEmpty
+        }
+
+        It "Should return no jobs when -Job is whitespace" {
+            $results = Get-DbaAgentJob -SqlInstance $TestConfig.instance2 -Job "   "
+            $results | Should -BeNullOrEmpty
+        }
+
+        It "Should ignore -ExcludeJob when it contains null values" {
+            $nullVariable = $null
+            $results = Get-DbaAgentJob -SqlInstance $TestConfig.instance2 -ExcludeJob $nullVariable
+            $results | Should -Not -BeNullOrEmpty
+        }
+    }
 }

tests/Remove-DbaAgentJob.Tests.ps1

@@ -123,4 +123,39 @@ Describe $CommandName -Tag IntegrationTests {
             ($server.Query("select 1 from sysjobhistory where job_id = '$jobId'", "msdb")) | Should -Not -BeNullOrEmpty
         }
     }
+
+    Context "Command validates null/empty Job parameter" {
+        BeforeAll {
+            $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
+            $null = New-DbaAgentJob -SqlInstance $TestConfig.instance3 -Job dbatoolsci_testjob_validation
+            $PSDefaultParameterValues.Remove("*-Dba*:EnableException")
+        }
+
+        AfterAll {
+            $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
+            if (Get-DbaAgentJob -SqlInstance $TestConfig.instance3 -Job dbatoolsci_testjob_validation) {
+                $null = Remove-DbaAgentJob -SqlInstance $TestConfig.instance3 -Job dbatoolsci_testjob_validation -Confirm:$false
+            }
+            $PSDefaultParameterValues.Remove("*-Dba*:EnableException")
+        }
+
+        It "Should not remove jobs when -Job is null" {
+            $nullVariable = $null
+            $result = Remove-DbaAgentJob -SqlInstance $TestConfig.instance3 -Job $nullVariable -Confirm:$false
+            $result | Should -BeNullOrEmpty
+            (Get-DbaAgentJob -SqlInstance $TestConfig.instance3 -Job dbatoolsci_testjob_validation) | Should -Not -BeNullOrEmpty
+        }
+
+        It "Should not remove jobs when -Job is empty string" {
+            $result = Remove-DbaAgentJob -SqlInstance $TestConfig.instance3 -Job "" -Confirm:$false
+            $result | Should -BeNullOrEmpty
+            (Get-DbaAgentJob -SqlInstance $TestConfig.instance3 -Job dbatoolsci_testjob_validation) | Should -Not -BeNullOrEmpty
+        }
+
+        It "Should not remove jobs when -Job is whitespace" {
+            $result = Remove-DbaAgentJob -SqlInstance $TestConfig.instance3 -Job "   " -Confirm:$false
+            $result | Should -BeNullOrEmpty
+            (Get-DbaAgentJob -SqlInstance $TestConfig.instance3 -Job dbatoolsci_testjob_validation) | Should -Not -BeNullOrEmpty
+        }
+    }
 } # $TestConfig.instance2 for appveyor