Update Key Vault name to dbatoolsci-runners-keyvault

Changed the Key Vault name from 'dbatoolsci' to 'dbatoolsci-runners-keyvault' in both the GitHub Actions workflow and Terraform variables to ensure consistency and correct resource referencing.

Author: potatoqualitee

.github/workflows/vmss-deploy.yml

@@ -35,11 +35,11 @@ jobs:
             echo "Resource group dbatools-ci-runners already exists"
           fi
 
-          if ! az keyvault show --name dbatoolsci --resource-group dbatools-ci-runners &>/dev/null; then
-            echo "Creating Key Vault dbatoolsci..."
-            az keyvault create --name dbatoolsci --resource-group dbatools-ci-runners --location eastus
+          if ! az keyvault show --name dbatoolsci-runners-keyvault --resource-group dbatools-ci-runners &>/dev/null; then
+            echo "Creating Key Vault dbatoolsci-runners-keyvault..."
+            az keyvault create --name dbatoolsci-runners-keyvault --resource-group dbatools-ci-runners --location eastus
           else
-            echo "Key Vault dbatoolsci already exists"
+            echo "Key Vault dbatoolsci-runners-keyvault already exists"
           fi
 
       - name: Extract Azure credentials for Terraform

gh-runners/variables.tfvars

@@ -3,7 +3,7 @@ location             = "eastus"
 vmss_name            = "dbatools-runner-vmss"
 image_resource_group = "dbatools-ci-images"
 image_name           = "dbatools-golden-image"
-keyvault_name        = "dbatoolsci"
+keyvault_name        = "dbatoolsci-runners-keyvault"
 min_instances        = 0
 max_instances        = 3
 github_organization  = "dataplat"