New-DbaLogin - Fix bug in PasswordMustChange (#9713)

Author: andreasjordan

public/New-DbaLogin.ps1

@@ -532,7 +532,7 @@ function New-DbaLogin {
                         }
 
                         #Process the MustChangePassword property
-                        if ($currentPasswordMustChange -ne $newLogin.MustChangePassword) {
+                        if ($null -ne $currentPasswordMustChange -and $currentPasswordMustChange -ne $newLogin.MustChangePassword) {
                             try {
                                 $newLogin.ChangePassword($SecurePassword, $true, $true)
                                 Write-Message -Level Verbose -Message "Login $loginName has been marked as must change password."

tests/New-DbaLogin.Tests.ps1

@@ -190,7 +190,7 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
         It "Should not have same properties because of the overrides" {
 
             $login1 = Get-DbaLogin -SqlInstance $TestConfig.instance1 -login claudio
-            $login2 = Get-DbaLogin -SqlInstance $TestConfig.instance2 -login withMustChange
+            $login2 = Get-DbaLogin -SqlInstance $TestConfig.instance2 -login claudio
 
             $login2 | Should Not BeNullOrEmpty
 
@@ -201,12 +201,11 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
             $login1.IsDisabled | Should Not be $login2.IsDisabled
             $login1.PasswordExpirationEnabled | Should Not be $login2.PasswordExpirationEnabled
             $login1.PasswordPolicyEnforced | Should Not be $login2.PasswordPolicyEnforced
-            $login1.MustChangePassword | Should Not be $login2.MustChangePassword
             $login1.Sid | Should Not be $login2.Sid
         }
         if ($IsWindows -ne $false) {
             It "Should create a disabled account with deny Windows login" {
-                $results = New-DbaLogin -SqlInstance $server1 -Login $winLogin -Disabled -DenyWindowsLogin
+                $results = New-DbaLogin -SqlInstance $server1 -Login $winLogin -Disabled -DenyWindowsLogin -Force
                 $results.Name | Should Be "$winLogin"
                 $results.DefaultDatabase | Should be 'master'
                 $results.IsDisabled | Should be $true

tests/pester.groups.ps1

@@ -35,7 +35,6 @@ $TestsRunGroups = @{
         'Dismount-DbaDatabase',
         # tests that fail locally against SQL Server 2022 instances and fail on AppVeyor
         'Set-DbaAgentJobStep',
-        'New-DbaLogin',
         'Watch-DbaDbLogin',
         # tests that fail because the command does not work
         'Copy-DbaDbCertificate',