Refactor some tests (#9738)

Author: andreasjordan

tests/Find-DbaStoredProcedure.Tests.ps1

@@ -32,7 +32,6 @@ AS
         $results = Find-DbaStoredProcedure -SqlInstance $TestConfig.instance2 -Pattern dbatools* -IncludeSystemDatabases
         It "Should find a specific StoredProcedure named cp_dbatoolsci_sysadmin" {
             $results.Name | Should Contain "cp_dbatoolsci_sysadmin"
-            $results.DatabaseId | Should -Be (Get-DbaDatabase -SqlInstance $TestConfig.instance2 -Database master).ID
         }
     }
     Context "Command finds Procedures in a User Database" {
@@ -52,7 +51,6 @@ AS
         $results = Find-DbaStoredProcedure -SqlInstance $TestConfig.instance2 -Pattern dbatools* -Database 'dbatoolsci_storedproceduredb'
         It "Should find a specific StoredProcedure named sp_dbatoolsci_custom" {
             $results.Name | Should Contain "sp_dbatoolsci_custom"
-            $results.DatabaseId | Should -Be (Get-DbaDatabase -SqlInstance $TestConfig.instance2 -Database dbatoolsci_storedproceduredb).ID
         }
         It "Should find sp_dbatoolsci_custom in dbatoolsci_storedproceduredb" {
             $results.Database | Should Contain "dbatoolsci_storedproceduredb"

tests/Get-DbaConnection.Tests.ps1

@@ -18,7 +18,7 @@ Describe "$CommandName Integration Tests" -Tag "IntegrationTests" {
         $results = Get-DbaConnection -SqlInstance $TestConfig.instance1
         foreach ($result in $results) {
             It "returns an scheme" {
-                $result.AuthScheme -eq 'ntlm' -or $result.AuthScheme -eq 'Kerberos' | Should -Be $true
+                $result.AuthScheme | Should -BeIn 'NTLM', 'Kerberos', 'SQL'
             }
         }
     }

tests/Invoke-DbaDbMirroring.Tests.ps1

@@ -15,23 +15,17 @@ Describe "$commandname Unit Tests" -Tag "UnitTests" {
 
 Describe "$commandname Integration Tests" -Tag "IntegrationTests" {
     BeforeAll {
-        $null = Get-DbaProcess -SqlInstance $TestConfig.instance2 | Where-Object Program -Match dbatools | Stop-DbaProcess -Confirm:$false -WarningAction SilentlyContinue
         $server = Connect-DbaInstance -SqlInstance $TestConfig.instance2
         $db1 = "dbatoolsci_mirroring"
 
-        Remove-DbaDbMirror -SqlInstance $TestConfig.instance2 -Database $db1 -Confirm:$false
-        Remove-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $db1 -Confirm:$false
-        $null = Get-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $db1 | Remove-DbaDatabase -Confirm:$false
-        $null = $server.Query("CREATE DATABASE $db1")
-
-        Get-DbaEndpoint -SqlInstance $TestConfig.instance2 -Type DatabaseMirroring | Remove-DbaEndpoint -Confirm:$false
-        New-DbaEndpoint -SqlInstance $TestConfig.instance2 -Name dbatoolsci_MirroringEndpoint -Type DatabaseMirroring -Port 5022 -Owner sa
-        Get-DbaEndpoint -SqlInstance $TestConfig.instance3 -Type DatabaseMirroring | Remove-DbaEndpoint -Confirm:$false
-        New-DbaEndpoint -SqlInstance $TestConfig.instance3 -Name dbatoolsci_MirroringEndpoint -Type DatabaseMirroring -Port 5023 -Owner sa
+        $null = New-DbaDatabase -SqlInstance $TestConfig.instance2 -Name $db1 -EnableException
+        $null = New-DbaEndpoint -SqlInstance $TestConfig.instance2 -Name dbatoolsci_MirroringEndpoint -Type DatabaseMirroring -Port 5022 -Owner sa -EnableException
+        $null = New-DbaEndpoint -SqlInstance $TestConfig.instance3 -Name dbatoolsci_MirroringEndpoint -Type DatabaseMirroring -Port 5023 -Owner sa -EnableException
     }
     AfterAll {
         $null = Remove-DbaDbMirror -SqlInstance $TestConfig.instance2, $TestConfig.instance3 -Database $db1 -Confirm:$false
-        $null = Remove-DbaDatabase -Confirm:$false -SqlInstance $TestConfig.instance2, $TestConfig.instance3 -Database $db1 -ErrorAction SilentlyContinue
+        $null = Remove-DbaDatabase -SqlInstance $TestConfig.instance2, $TestConfig.instance3 -Database $db1 -Confirm:$false
+        $null = Remove-DbaEndpoint -SqlInstance $TestConfig.instance2, $TestConfig.instance3 -EndPoint dbatoolsci_MirroringEndpoint -Confirm:$false
     }
 
     It "returns success" {

tests/Invoke-DbaQuery.Tests.ps1

@@ -56,6 +56,8 @@ Describe "$CommandName Integration Tests" -Tag "IntegrationTests" {
         try {
             $null = $db.Query("DROP PROCEDURE dbo.dbatoolsci_procedure_example")
             $null = $db.Query("DROP PROCEDURE dbo.my_proc")
+            $null = $db.Query("DROP PROCEDURE dbo.usp_Insertsomething")
+            $null = $db.Query("DROP TYPE dbo.dbatools_tabletype")
         } catch {
             $null = 1
         }
@@ -85,7 +87,7 @@ Describe "$CommandName Integration Tests" -Tag "IntegrationTests" {
         }
     }
     It "supports pipable databases" {
-        $dbs = Get-DbaDatabase -SqlInstance $TestConfig.instance2, $TestConfig.instance3
+        $dbs = Get-DbaDatabase -SqlInstance $TestConfig.instance2, $TestConfig.instance3 -Database tempdb
         $results = $dbs | Invoke-DbaQuery -Query "Select 'hello' as TestColumn, DB_NAME() as dbname"
         foreach ($result in $results) {
             $result.TestColumn | Should -Be 'hello'

tests/Measure-DbaBackupThroughput.Tests.ps1

@@ -22,7 +22,7 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
             $null = New-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $db | Backup-DbaDatabase
         }
         AfterAll {
-            $null = Remove-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $db
+            $null = Remove-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $db -Confirm:$false
         }
 
         $results = Measure-DbaBackupThroughput -SqlInstance $TestConfig.instance2 -Database $db