Fix test for Copy-DbaLinkedServer (#9516)

andreasjordan · web-flow · commit e7e5b2bbbf8a · 2024-10-16T14:14:16.000+02:00
diff --git a/tests/Copy-DbaLinkedServer.Tests.ps1 b/tests/Copy-DbaLinkedServer.Tests.ps1
@@ -55,7 +55,8 @@ Describe "$commandname Integration Tests" -Tags "IntegrationTests" {
             $results.Status | Should Be "Skipped"
         }
 
-        It "upgrades SQLNCLI provider based on what is registered" {
+        # SQLNCLI10 and SQLNCLI11 are not used on newer versions, not sure which versions, but skipping if later than 2017
+        It -Skip:$($server1.VersionMajor -gt 14 -or $server2.VersionMajor -gt 14) "upgrades SQLNCLI provider based on what is registered" {
             $result = Copy-DbaLinkedServer -Source $script:instance2 -Destination $script:instance3 -LinkedServer dbatoolsci_localhost2 -UpgradeSqlClient
             $server1 = Connect-DbaInstance -SqlInstance $script:instance2
             $server2 = Connect-DbaInstance -SqlInstance $script:instance3

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,8 @@ Describe "$commandname Integration Tests" -Tags "IntegrationTests" {`
`55`	`55`	`$results.Status \| Should Be "Skipped"`
`56`	`56`	`}`
`57`	`57`
`58`		`- It "upgrades SQLNCLI provider based on what is registered" {`
	`58`	`+ # SQLNCLI10 and SQLNCLI11 are not used on newer versions, not sure which versions, but skipping if later than 2017`
	`59`	`+ It -Skip:$($server1.VersionMajor -gt 14 -or $server2.VersionMajor -gt 14) "upgrades SQLNCLI provider based on what is registered" {`
`59`	`60`	`$result = Copy-DbaLinkedServer -Source $script:instance2 -Destination $script:instance3 -LinkedServer dbatoolsci_localhost2 -UpgradeSqlClient`
`60`	`61`	`$server1 = Connect-DbaInstance -SqlInstance $script:instance2`
`61`	`62`	`$server2 = Connect-DbaInstance -SqlInstance $script:instance3`