Proposal to avoid "Collection was modified"

[potatoqualitee]

Remove commands can cause issues when we pipe because the original collection was modified.

You can see us awkwardly try to handle that in Get-DbaDatabase. To avoid all that, I propose the way I'm doing it with ExtendedProperties. Use T-SQL with a command called Get-ConnectionParent https://github.com/sqlcollaborative/dbatools/blob/extended/internal/functions/Get-ConnectionParent.ps1

Then something like this.

               $db = $object | Get-ConnectionParent -Database
                try {
                    $null = $db.Invoke("EXEC sp_dropextendedproperty @name = N'$($object.Name)'; ")
                    [pscustomobject]@{
                        ComputerName = $object.ComputerName
                        InstanceName = $object.InstanceName
                        SqlInstance  = $object.SqlInstance
                        ParentName   = $object.ParentName
                        Type         = $object.Type
                        Name         = $object.Name
                        Status       = "Dropped"
                    }
                } catch {
                    Stop-Function -Message "Failure" -ErrorRecord $_ -Continue
                }