Add RDS allocated storage, storage type and engine variables

Author: dpf

README.md

@@ -113,11 +113,14 @@ For now the only authentication option is 'RBAC'. When enabling this, this modul
 | rbac\_admin\_lastname | RBAC Lastname (only when airflow\_authentication = 'rbac') | `string` | `"airflow"` | no |
 | rbac\_admin\_password | RBAC Password (only when airflow\_authentication = 'rbac') | `string` | `"admin"` | no |
 | rbac\_admin\_username | RBAC Username (only when airflow\_authentication = 'rbac') | `string` | `"admin"` | no |
+| rds\_allocated\_storage | The allocated storage for the rds db in gibibytes | `number` | `20` | no |
 | rds\_availability\_zone | Availability zone for the rds instance | `string` | `"eu-west-1a"` | no |
 | rds\_deletion\_protection | Deletion protection for the rds instance | `bool` | `false` | no |
+| rds\_engine | The database engine to use. For supported values, see the Engine parameter in [API action CreateDBInstance](https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html) | `string` | `"postgres"` | no |
 | rds\_instance\_class | The class of instance you want to give to your rds db | `string` | `"db.t2.micro"` | no |
 | rds\_password | Password of rds | `string` | `""` | no |
 | rds\_skip\_final\_snapshot | Whether or not to skip the final snapshot before deleting (mainly for tests) | `bool` | `false` | no |
+| rds\_storage\_type | One of `"standard"` (magnetic), `"gp2"` (general purpose SSD), or `"io1"` (provisioned IOPS SSD) | `string` | `"standard"` | no |
 | rds\_username | Username of rds | `string` | `"airflow"` | no |
 | region | The region to deploy your solution to | `string` | `"eu-west-1"` | no |
 | resource\_prefix | A prefix for the create resources, example your company name (be aware of the resource name length) | `string` | n/a | yes |
@@ -165,4 +168,4 @@ Make sure you branch from the 'open-pr-here' branch, and submit a PR back to the
 
 ## License
 
-MIT license. Please see [LICENSE](LICENSE.md) for details.
+MIT license. Please see [LICENSE](LICENSE.md) for details.

rds.tf

@@ -1,9 +1,9 @@
 resource "aws_db_instance" "airflow" {
   count                     = var.postgres_uri != "" || var.airflow_executor == "Sequential" ? 0 : 1
   name                      = replace(title(local.rds_name), "-", "")
-  allocated_storage         = 20
-  storage_type              = "standard"
-  engine                    = "postgres"
+  allocated_storage         = var.rds_allocated_storage
+  storage_type              = var.rds_storage_type
+  engine                    = var.rds_engine
   engine_version            = "11.8"
   instance_class            = var.rds_instance_class
   username                  = var.rds_username
@@ -27,4 +27,4 @@ resource "aws_db_subnet_group" "airflow" {
   subnet_ids = local.rds_ecs_subnet_ids
 
   tags = local.common_tags
-}
+}

variables.tf

@@ -206,7 +206,29 @@ variable "postgres_uri" {
   default     = ""
 }
 
-// TODO: Add more rds params
+variable "rds_allocated_storage" {
+  type        = number
+  description = "The allocated storage for the rds db in gibibytes"
+  default     = 20
+}
+
+variable "rds_storage_type" {
+  type        = string
+  description = <<EOT
+  One of "standard" (magnetic), "gp2" (general purpose SSD), or "io1" (provisioned IOPS SSD)
+  EOT
+  default     = "standard"
+}
+
+variable "rds_engine" {
+  type        = string
+  description = <<EOT
+  The database engine to use. For supported values, see the Engine parameter in 
+  [API action CreateDBInstance](https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html)
+  EOT
+  default     = "postgres"
+}
+
 variable "rds_username" {
   type        = string
   description = "Username of rds"