Skip to content

Commit f485266

Browse files
committed
Applied suggested simplification
1 parent f73e1eb commit f485266

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/main/java/dev/dsf/bpe/service/ping/CheckPingTaskStatus.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,21 +46,20 @@ protected void doExecute(DelegateExecution delegateExecution, Variables variable
4646
try
4747
{
4848
Task pingTask = fhirWebserviceClient.withRetry(3, 1000).read(Task.class, taskId);
49-
switch (pingTask.getStatus())
49+
error = switch (pingTask.getStatus())
5050
{
51-
case REQUESTED, INPROGRESS, FAILED, COMPLETED -> error = new ProcessError(
52-
CodeSystem.DsfPingProcesses.Code.PING,
51+
case REQUESTED, INPROGRESS, FAILED, COMPLETED -> new ProcessError(CodeSystem.DsfPingProcesses.Code.PING,
5352
CodeSystem.DsfPingProcessSteps.Code.CHECK_PING_TASK_STATUS, "Awaiting pong message", null,
5453
"Pong message timed out. Status of ping task resource with id " + taskId + " from "
5554
+ target.getEndpointUrl() + " is " + pingTask.getStatus());
56-
default -> error = new ProcessError(CodeSystem.DsfPingProcesses.Code.PING,
55+
default -> new ProcessError(CodeSystem.DsfPingProcesses.Code.PING,
5756
CodeSystem.DsfPingProcessSteps.Code.CHECK_PING_TASK_STATUS, "Awaiting pong message", null,
5857
"Pong message timed out. Status of ping task resource with id " + taskId + " from "
5958
+ target.getEndpointUrl() + " is " + pingTask.getStatus()
6059
+ ". Unexpected status. Should be either of " + Task.TaskStatus.REQUESTED + ", "
6160
+ Task.TaskStatus.INPROGRESS + ", " + Task.TaskStatus.COMPLETED + " or "
6261
+ Task.TaskStatus.FAILED);
63-
}
62+
};
6463
}
6564
catch (WebApplicationException e)
6665
{

0 commit comments

Comments
 (0)