Skip to content

Commit 504749a

Browse files
committed
unnamed variables, code cleanup
* Changed unused variables to unnamed variables (underscore) * Some code cleanup
1 parent 07b21dc commit 504749a

File tree

31 files changed

+65
-66
lines changed

31 files changed

+65
-66
lines changed

dsf-bpe/dsf-bpe-process-api-v1-impl/src/main/java/dev/dsf/bpe/v1/service/OrganizationProviderImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,6 @@ public List<Organization> getRemoteOrganizations()
141141

142142
Map<String, List<String>> searchParameters = Map.of("active", List.of("true"), "identifier:not",
143143
List.of(toSearchParameter(localOrganizationIdentifier.get())));
144-
return search(Organization.class, searchParameters, SearchEntryMode.MATCH, Organization.class, o -> true);
144+
return search(Organization.class, searchParameters, SearchEntryMode.MATCH, Organization.class, _ -> true);
145145
}
146146
}

dsf-bpe/dsf-bpe-process-api-v1-impl/src/main/java/dev/dsf/fhir/authorization/read/ReadAccessHelperImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ public boolean hasAll(Resource resource)
284284
@Override
285285
public boolean isValid(Resource resource)
286286
{
287-
return isValid(resource, organizationIdentifier -> true, role -> true);
287+
return isValid(resource, _ -> true, _ -> true);
288288
}
289289

290290
@Override

dsf-bpe/dsf-bpe-process-api-v1/src/main/java/dev/dsf/fhir/authorization/process/ProcessAuthorizationHelperImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ public Stream<Requester> getRequesters(ActivityDefinition activityDefinition, St
322322
.equals(e.getUrl()))
323323
.filter(Extension::hasValue).filter(e -> e.getValue() instanceof Coding)
324324
.map(e -> (Coding) e.getValue())
325-
.flatMap(coding -> requesterFrom(coding, c -> true, i -> true, c -> true).stream());
325+
.flatMap(coding -> requesterFrom(coding, _ -> true, _ -> true, _ -> true).stream());
326326
}
327327

328328
@Override
@@ -340,7 +340,7 @@ public Stream<Recipient> getRecipients(ActivityDefinition activityDefinition, St
340340
.equals(e.getUrl()))
341341
.filter(Extension::hasValue).filter(e -> e.getValue() instanceof Coding)
342342
.map(e -> (Coding) e.getValue())
343-
.flatMap(coding -> recipientFrom(coding, i -> true, c -> true).stream());
343+
.flatMap(coding -> recipientFrom(coding, _ -> true, _ -> true).stream());
344344
}
345345

346346
private Optional<Extension> getAuthorizationExtension(ActivityDefinition activityDefinition, String processUrl,

dsf-bpe/dsf-bpe-process-api-v2-impl/src/main/java/dev/dsf/bpe/v2/service/OrganizationProviderImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,14 +142,14 @@ public List<Organization> getRemoteOrganizations()
142142
Map<String, List<String>> searchParameters = Map.of("active", List.of("true"), "identifier:not",
143143
List.of(toSearchParameter(localOrganizationIdentifier.get())), "_profile",
144144
List.of("http://dsf.dev/fhir/StructureDefinition/organization"));
145-
return search(Organization.class, searchParameters, SearchEntryMode.MATCH, Organization.class, o -> true);
145+
return search(Organization.class, searchParameters, SearchEntryMode.MATCH, Organization.class, _ -> true);
146146
}
147147

148148
@Override
149149
public List<Organization> getParentOrganizations()
150150
{
151151
Map<String, List<String>> searchParameters = Map.of("active", List.of("true"), "_profile",
152152
List.of("http://dsf.dev/fhir/StructureDefinition/organization-parent"));
153-
return search(Organization.class, searchParameters, SearchEntryMode.MATCH, Organization.class, o -> true);
153+
return search(Organization.class, searchParameters, SearchEntryMode.MATCH, Organization.class, _ -> true);
154154
}
155155
}

dsf-bpe/dsf-bpe-process-api-v2-impl/src/main/java/dev/dsf/bpe/v2/service/ReadAccessHelperImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ public boolean hasAll(Resource resource)
298298
@Override
299299
public boolean isValid(Resource resource)
300300
{
301-
return isValid(resource, organizationIdentifier -> true, role -> true);
301+
return isValid(resource, _ -> true, _ -> true);
302302
}
303303

304304
@Override

dsf-bpe/dsf-bpe-process-api-v2-impl/src/main/java/dev/dsf/bpe/v2/service/process/ProcessAuthorizationHelperImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ public Stream<Requester> getRequesters(ActivityDefinition activityDefinition, St
437437
.filter(e -> EXTENSION_PROCESS_AUTHORIZATION_REQUESTER.equals(e.getUrl()))
438438
.filter(Extension::hasValue).filter(e -> e.getValue() instanceof Coding)
439439
.map(e -> (Coding) e.getValue())
440-
.flatMap(coding -> requesterFrom(coding, c -> true, i -> true, c -> true).stream());
440+
.flatMap(coding -> requesterFrom(coding, _ -> true, _ -> true, _ -> true).stream());
441441
}
442442

443443
@Override
@@ -454,7 +454,7 @@ public Stream<Recipient> getRecipients(ActivityDefinition activityDefinition, St
454454
.filter(e -> EXTENSION_PROCESS_AUTHORIZATION_RECIPIENT.equals(e.getUrl()))
455455
.filter(Extension::hasValue).filter(e -> e.getValue() instanceof Coding)
456456
.map(e -> (Coding) e.getValue())
457-
.flatMap(coding -> recipientFrom(coding, i -> true, c -> true).stream());
457+
.flatMap(coding -> recipientFrom(coding, _ -> true, _ -> true).stream());
458458
}
459459

460460
private Optional<Extension> getAuthorizationExtension(ActivityDefinition activityDefinition, String processUrl,

dsf-bpe/dsf-bpe-process-api-v2/src/main/java/dev/dsf/bpe/v2/activity/task/DefaultTaskSender.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ protected static record TaskAndConfig(Task task, String instantiatesCanonical, S
4444
public DefaultTaskSender(ProcessPluginApi api, Variables variables, SendTaskValues sendTaskValues,
4545
BusinessKeyStrategy businessKeyStrategy)
4646
{
47-
this(api, variables, sendTaskValues, businessKeyStrategy, t -> List.of());
47+
this(api, variables, sendTaskValues, businessKeyStrategy, _ -> List.of());
4848
}
4949

5050
public DefaultTaskSender(ProcessPluginApi api, Variables variables, SendTaskValues sendTaskValues,

dsf-bpe/dsf-bpe-process-api/src/main/java/dev/dsf/bpe/api/plugin/AbstractProcessPlugin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ public boolean initializeAndValidateResources(String localOrganizationIdentifier
247247
}
248248

249249
Map<String, Integer> processCounts = models.stream()
250-
.collect(Collectors.toMap(m -> m.toProcessIdAndVersion().getId(), m -> 1, (c1, c2) -> c1 + c2));
250+
.collect(Collectors.toMap(m -> m.toProcessIdAndVersion().getId(), _ -> 1, (c1, c2) -> c1 + c2));
251251
if (processCounts.values().stream().anyMatch(c -> c > 1))
252252
{
253253
logger.warn("Ignoring process plugin {}-{} from {}: Processes with duplicate IDs found {}",
@@ -1164,7 +1164,7 @@ private boolean isValidQuestionnaire(String file, Object resource)
11641164
private Object modifyBaseDefinitionIfTaskProfile(Object resource, String file)
11651165
{
11661166
Optional<String> baseDefinition = fhirConfig.getStructureDefinitionBaseDefinition(resource);
1167-
baseDefinition.filter(d -> STRUCTURE_DEFINITION_BASE_TASK_URL_V1.equals(d)).ifPresent(d ->
1167+
baseDefinition.filter(d -> STRUCTURE_DEFINITION_BASE_TASK_URL_V1.equals(d)).ifPresent(_ ->
11681168
{
11691169
logger.info(
11701170
"Setting StructureDefinition.baseDefinition to {} for FHIR resource {} from process plugin {}-{}",

dsf-bpe/dsf-bpe-server/src/main/java/dev/dsf/bpe/camunda/MultiVersionClassDelegateActivityBehavior.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,14 @@ protected ActivityBehavior getActivityBehaviorInstance(ActivityExecution executi
4040

4141
JavaDelegate delegate = switch (e.getBpmnModelElementInstance())
4242
{
43-
case SendTask st ->
43+
case SendTask _ ->
4444
delegateProvider.getMessageSendTask(processKeyAndVersion, className, fieldDeclarations, execution);
45-
case ServiceTask st ->
45+
case ServiceTask _ ->
4646
delegateProvider.getServiceTask(processKeyAndVersion, className, fieldDeclarations, execution);
47-
case EndEvent ee ->
47+
case EndEvent _ ->
4848
delegateProvider.getMessageEndEvent(processKeyAndVersion, className, fieldDeclarations, execution);
49-
case IntermediateThrowEvent ite -> delegateProvider.getMessageIntermediateThrowEvent(
50-
processKeyAndVersion, className, fieldDeclarations, execution);
49+
case IntermediateThrowEvent _ -> delegateProvider.getMessageIntermediateThrowEvent(processKeyAndVersion,
50+
className, fieldDeclarations, execution);
5151

5252
default -> throw new IllegalArgumentException("Unexpected value: " + e.getBpmnModelElementInstance());
5353
};

dsf-bpe/dsf-bpe-server/src/main/java/dev/dsf/bpe/mail/SmtpMailService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,8 @@ private Log4jAppender(Session session, MimeMessage message, String subject, int
156156
MailManagerFactory factory = (name, data) -> new SmtpManager(name, session, message, data)
157157
{
158158
};
159-
FactoryData data = new FactoryData(null, null, null, null, null, null, event -> subject, null, null, 0,
160-
null, null, false, messageBufferSize, null, null);
159+
FactoryData data = new FactoryData(null, null, null, null, null, null, _ -> subject, null, null, 0, null,
160+
null, false, messageBufferSize, null, null);
161161
manager = AbstractManager.getManager("SmtpMailService.Log4jAppender.Manager", factory, data);
162162
}
163163

0 commit comments

Comments
 (0)