Skip to content

Commit c45f65e

Browse files
committed
improved log and exception messages
1 parent d4d35dd commit c45f65e

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

dsf-common/dsf-common-jetty/src/main/java/dev/dsf/common/auth/BackChannelLogoutAuthenticator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ public AuthenticationState validateRequest(Request request, Response response, C
131131
catch (JWTVerificationException | OidcClientException e)
132132
{
133133
logger.debug("Backchannel logout failed, sending 400", e);
134-
logger.warn("Backchannel logout, sending 400: {} - {}", e.getClass().getName(), e.getMessage());
134+
logger.warn("Backchannel logout failed, sending 400: {} - {}", e.getClass().getName(), e.getMessage());
135135

136136
Response.writeError(request, response, callback, HttpStatus.BAD_REQUEST_400);
137137
return AuthenticationState.SEND_FAILURE;

dsf-common/dsf-common-oidc/src/main/java/dev/dsf/common/oidc/Jwks.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ yield switch (alg)
9898
};
9999
}
100100

101-
default -> throw new JwksException("JWKS kty property '" + kty + "' not supported");
101+
default -> throw new JwksException("JWKS kty property value '" + kty + "' not one of 'RSA' or 'EC'");
102102
};
103103
}
104104

@@ -186,7 +186,7 @@ private ECPublicKey toEcPublicKey(String x, String y, String crv)
186186
case "P-521" -> new ECGenParameterSpec("secp521r1");
187187

188188
default -> throw new JwksException(
189-
"JWKS crv property value '" + crv + "' not one of 'P-256', 'P-384' or 'P-512'");
189+
"JWKS crv property value '" + crv + "' not one of 'P-256', 'P-384' or 'P-521'");
190190
};
191191

192192
try

dsf-fhir/dsf-fhir-validation/src/main/java/dev/dsf/fhir/validation/SnapshotGeneratorImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public SnapshotWithValidationMessages generateSnapshot(StructureDefinition diffe
6969
if (base == null)
7070
logger.warn("Base definition with url {} not found", differential.getBaseDefinition());
7171
else if (!base.hasSnapshot())
72-
logger.warn("Base definition with url {} has not snapshot", differential.getBaseDefinition());
72+
logger.warn("Base definition with url {} has no snapshot", differential.getBaseDefinition());
7373

7474
/* ProfileUtilities is not thread safe */
7575
List<ValidationMessage> messages = new ArrayList<>();

0 commit comments

Comments
 (0)