Skip to content

Commit ecd471f

Browse files
committed
Remove Sort from deleteOne
1 parent 02716eb commit ecd471f

File tree

3 files changed

+2
-34
lines changed

3 files changed

+2
-34
lines changed

astra-db-java/src/main/java/com/datastax/astra/client/tables/Table.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -919,14 +919,8 @@ public void deleteOne(Filter filter) {
919919
public void deleteOne(Filter filter, TableDeleteOneOptions deleteOneOptions) {
920920
Command deleteOne = Command
921921
.create("deleteOne")
922-
.withFilter(filter)
923-
.withSort(deleteOneOptions.getSortArray());
922+
.withFilter(filter);
924923
runCommand(deleteOne, deleteOneOptions);
925-
/*
926-
DataAPIResponse apiResponse = runCommand(deleteOne, deleteOneOptions);
927-
int deletedCount = apiResponse.getStatus().getInteger(RESULT_DELETED_COUNT);
928-
return new TableDeleteResult(deletedCount);
929-
*/
930924
}
931925

932926
// -------------------------

astra-db-java/src/main/java/com/datastax/astra/client/tables/commands/options/TableDeleteOneOptions.java

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -34,36 +34,9 @@
3434
@Accessors(fluent = true, chain = true)
3535
public class TableDeleteOneOptions extends BaseOptions<TableDeleteOneOptions> {
3636

37-
/**
38-
* Order by.
39-
*/
40-
Sort[] sort;
41-
4237
/**
4338
* Default constructor.
4439
*/
4540
public TableDeleteOneOptions() {}
4641

47-
/**
48-
* Adding this on top of sort(Sort[] s) to allow for a more fluent API.
49-
* @param s
50-
* sort options
51-
* @return
52-
* current command
53-
*/
54-
public TableDeleteOneOptions sort(Sort... s) {
55-
this.sort = s;
56-
return this;
57-
}
58-
59-
60-
/**
61-
* Get the sort options.
62-
*
63-
* @return
64-
* sort options
65-
*/
66-
public Sort[] getSortArray() {
67-
return sort;
68-
}
6942
}

astra-db-java/src/test/java/com/datastax/astra/test/integration/local/LocalTableITTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import com.datastax.astra.client.tables.commands.options.CreateTableOptions;
2626
import com.datastax.astra.client.tables.commands.options.CreateVectorIndexOptions;
2727
import com.datastax.astra.client.tables.commands.options.DropTableIndexOptions;
28+
import com.datastax.astra.client.tables.commands.options.TableDeleteOneOptions;
2829
import com.datastax.astra.client.tables.commands.options.TableFindOneOptions;
2930
import com.datastax.astra.client.tables.commands.options.TableFindOptions;
3031
import com.datastax.astra.client.tables.commands.options.TableInsertManyOptions;

0 commit comments

Comments
 (0)