Throw readable error if passing endpoint and keyspace as a string to db() (#55)

"Unexpected db() argument: database id can't start with "https://". Did you mean to call .db(endpoint, { namespace })?"

Author: vkarpov15

src/data-api/db.ts

@@ -489,6 +489,10 @@ export function mkDb(rootOpts: InternalRootClientOpts, endpointOrId: string, reg
 
   validateDbOpts(options);
 
+  if (typeof regionOrOptions === 'string' && endpointOrId.startsWith('https://')) {
+    throw new Error('Unexpected db() argument: database id can\'t start with "https://". Did you mean to call `.db(endpoint, { namespace })`?');
+  }
+ 
   const endpoint = (typeof regionOrOptions === 'string')
     ? 'https://' + endpointOrId + '-' + regionOrOptions + '.apps.astra.datastax.com'
     : endpointOrId;

tests/integration/client/data-api-client.test.ts

@@ -286,5 +286,13 @@ describe('integration.client.data-api-client', () => {
       assert.ok(failedEvent.error instanceof DataAPITimeoutError);
       assert.strictEqual(failedEvent.error.timeout, 1);
     });
+
+    it('throws an error if passing in endpoint and keyspace name as a string', () => {
+      const client = new DataAPIClient(TEST_APPLICATION_TOKEN);
+      assert.throws(
+        () => client.db(TEST_ASTRA_URI, OTHER_NAMESPACE),
+        { message: 'Unexpected db() argument: database id can\'t start with "https://". Did you mean to call `.db(endpoint, { namespace })`?' }
+      );
+    });
   });
 });