Skip to content

Commit 6b0c2c0

Browse files
committed
CDM-93: Allow reserved keywords in target column-names. Update mem args in readme
1 parent f93df11 commit 6b0c2c0

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

README.md

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,13 @@ tar -xvzf spark-3.3.1-bin-hadoop3.tgz
3636
```
3737
./spark-submit --properties-file cdm.properties /
3838
--conf spark.cdm.schema.origin.keyspaceTable="<keyspacename>.<tablename>" /
39-
--master "local[*]" /
39+
--master "local[*]" --driver-memory 25G --executor-memory 25G /
4040
--class com.datastax.cdm.job.Migrate cassandra-data-migrator-4.x.x.jar &> logfile_name_$(date +%Y%m%d_%H_%M).txt
4141
```
4242

4343
Note:
44-
- Above command generates a log file `logfile_name.txt` to avoid log output on the console.
45-
- Add option `--driver-memory 25G --executor-memory 25G` as shown below if the table migrated is large (over 100GB)
46-
```
47-
./spark-submit --properties-file cdm.properties /
48-
--conf spark.cdm.schema.origin.keyspaceTable="<keyspacename>.<tablename>" /
49-
--master "local[*]" --driver-memory 25G --executor-memory 25G /
50-
--class com.datastax.cdm.job.Migrate cassandra-data-migrator-4.x.x.jar &> logfile_name_$(date +%Y%m%d_%H_%M).txt
51-
```
44+
- Above command generates a log file `logfile_name_*.txt` to avoid log output on the console.
45+
- Update the memory options (driver & executor memory) based on your use-case
5246

5347
# Steps for Data-Validation:
5448

@@ -57,7 +51,7 @@ Note:
5751
```
5852
./spark-submit --properties-file cdm.properties /
5953
--conf spark.cdm.schema.origin.keyspaceTable="<keyspacename>.<tablename>" /
60-
--master "local[*]" /
54+
--master "local[*]" --driver-memory 25G --executor-memory 25G /
6155
--class com.datastax.cdm.job.DiffData cassandra-data-migrator-4.x.x.jar &> logfile_name_$(date +%Y%m%d_%H_%M).txt
6256
```
6357

@@ -97,7 +91,7 @@ Each line above represents a partition-range (`min,max`). Alternatively, you can
9791
./spark-submit --properties-file cdm.properties /
9892
--conf spark.cdm.schema.origin.keyspaceTable="<keyspacename>.<tablename>" /
9993
--conf spark.cdm.tokenRange.partitionFile="/<path-to-file>/<csv-input-filename>" /
100-
--master "local[*]" /
94+
--master "local[*]" --driver-memory 25G --executor-memory 25G /
10195
--class com.datastax.cdm.job.<Migrate|DiffData> cassandra-data-migrator-4.x.x.jar &> logfile_name_$(date +%Y%m%d_%H_%M).txt
10296
```
10397
This mode is specifically useful to processes a subset of partition-ranges that may have failed during a previous run.
@@ -111,7 +105,7 @@ This mode is specifically useful to processes a subset of partition-ranges that
111105
./spark-submit --properties-file cdm.properties /
112106
--conf spark.cdm.schema.origin.keyspaceTable="<keyspacename>.<tablename>" /
113107
--conf spark.cdm.feature.guardrail.colSizeInKB=10000 /
114-
--master "local[*]" /
108+
--master "local[*]" --driver-memory 25G --executor-memory 25G /
115109
--class com.datastax.cdm.job.GuardrailCheck cassandra-data-migrator-4.x.x.jar &> logfile_name_$(date +%Y%m%d_%H_%M).txt
116110
```
117111

RELEASE.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
# Release Notes
2+
## [4.1.5] - 2023-08-29
3+
- Allow reserved keywords used as Target column-names
4+
25
## [4.1.4] - 2023-08-16
36
- In rare edge situations, counter tables with existing data in Target can have null values on target. This release will handle null values in Target counter table transparently.
47

src/main/java/com/datastax/cdm/cql/statement/TargetUpsertStatement.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@ public TargetUpsertStatement(IPropertyHelper propertyHelper, EnhancedSession ses
4848
explodeMapFeature = (ExplodeMap) cqlTable.getFeature(Featureset.EXPLODE_MAP);
4949

5050
setTTLAndWriteTimeBooleans();
51-
targetColumnNames.addAll(cqlTable.getColumnNames(false));
51+
targetColumnNames.addAll(cqlTable.getColumnNames(true));
5252
targetColumnTypes.addAll(cqlTable.getColumnCqlTypes());
53-
originColumnNames.addAll(cqlTable.getOtherCqlTable().getColumnNames(false));
53+
originColumnNames.addAll(cqlTable.getOtherCqlTable().getColumnNames(true));
5454
originColumnTypes.addAll(cqlTable.getOtherCqlTable().getColumnCqlTypes());
5555
setConstantColumns();
5656
if (null!=explodeMapFeature && explodeMapFeature.isEnabled()) {
@@ -153,4 +153,4 @@ else if (!cqlTable.getBindClass(explodeMapValueIndex).isAssignableFrom(explodeMa
153153
}
154154
}
155155

156-
}
156+
}

0 commit comments

Comments
 (0)