Feat/scb autodownload (#365)

* Auto-download Astra DB SCB
* add more unit test coverage
* Reuse CONNECT_PASSWORD as opposed to new Astra token properties
* simplify
* File path fix
* Improved error reporting
---------

Co-authored-by: Madhavan Sridharan <[email protected]>

Author: pravinbhat

src/main/java/com/datastax/cdm/data/AstraDevOpsClient.java

@@ -72,15 +72,15 @@ public AstraDevOpsClient(IPropertyHelper propertyHelper) {
      * @throws IOException
      *             If an error occurs during the download process
      */
-    public String downloadSecureBundle(PKFactory.Side side) throws IOException {
+    public String downloadSecureBundle(PKFactory.Side side) throws Exception {
         String token = getAstraToken(side);
         String databaseId = getAstraDatabaseId(side);
         String dbRegion = getRegion(side);
         String scbType = getScbType(side);
 
         if (token == null || token.isEmpty() || databaseId == null || databaseId.isEmpty()) {
-            logger.warn("Missing required Astra parameters for {} (token or database ID)", side);
-            return null;
+            logger.error("Missing required Astra parameters for {} (token or database ID)", side);
+            throw new Exception("Failed to download secure bundle");
         }
 
         logger.info("Auto-downloading secure connect bundle for {} database ID: {}, type: {}, region: {}", side,
@@ -91,14 +91,14 @@ public String downloadSecureBundle(PKFactory.Side side) throws IOException {
 
             if (jsonResponse == null) {
                 logger.error("Failed to fetch secure bundle URL info for {}", side);
-                return null;
+                throw new Exception("Failed to download secure bundle");
             }
 
             String downloadUrl = extractDownloadUrl(jsonResponse, scbType, side, dbRegion);
 
             if (downloadUrl == null) {
                 logger.error("Could not extract download URL for {} bundle type: {}", side, scbType);
-                return null;
+                throw new Exception("Failed to download secure bundle");
             }
 
             return downloadBundleFile(downloadUrl, side);

src/main/scala/com/datastax/cdm/job/ConnectionFetcher.scala

@@ -55,8 +55,8 @@ class ConnectionFetcher(propertyHelper: IPropertyHelper, testAstraClient: AstraD
         }
       } catch {
         case e: Exception => 
-          logger.warn(s"Failed to auto-download secure bundle for $side: ${e.getMessage}")
-          logger.debug("Auto-download failure details", e)
+          logger.error(s"Failed to auto-download secure bundle for $side: ${e.getMessage}")
+          logger.error("Auto-download failure details", e)
       }
     }
 

src/test/java/com/datastax/cdm/data/AstraDevOpsClientTest.java

@@ -38,7 +38,6 @@
 
 import com.datastax.cdm.properties.IPropertyHelper;
 import com.datastax.cdm.properties.KnownProperties;
-import com.fasterxml.jackson.databind.ObjectMapper;
 
 @ExtendWith(MockitoExtension.class)
 class AstraDevOpsClientTest {
@@ -69,42 +68,39 @@ void setUp() throws Exception {
     }
 
     @Test
-    void testDownloadSecureBundleWithNullToken() throws IOException {
+    void testDownloadSecureBundleWithNullToken() throws Exception {
         // Setup
         when(propertyHelper.getAsString(KnownProperties.CONNECT_ORIGIN_PASSWORD)).thenReturn(null);
 
         // Test
-        String result = client.downloadSecureBundle(PKFactory.Side.ORIGIN);
+        assertThrows(Exception.class, () -> client.downloadSecureBundle(PKFactory.Side.ORIGIN));
 
         // Verify
-        assertNull(result);
         verify(propertyHelper).getAsString(KnownProperties.CONNECT_ORIGIN_PASSWORD);
     }
 
     @Test
-    void testDownloadSecureBundleWithEmptyToken() throws IOException {
+    void testDownloadSecureBundleWithEmptyToken() throws Exception {
         // Setup
         when(propertyHelper.getAsString(KnownProperties.CONNECT_ORIGIN_PASSWORD)).thenReturn("");
 
         // Test
-        String result = client.downloadSecureBundle(PKFactory.Side.ORIGIN);
+        assertThrows(Exception.class, () -> client.downloadSecureBundle(PKFactory.Side.ORIGIN));
 
         // Verify
-        assertNull(result);
         verify(propertyHelper).getAsString(KnownProperties.CONNECT_ORIGIN_PASSWORD);
     }
 
     @Test
-    void testDownloadSecureBundleWithNullDatabaseId() throws IOException {
+    void testDownloadSecureBundleWithNullDatabaseId() throws Exception {
         // Setup
         when(propertyHelper.getAsString(KnownProperties.CONNECT_ORIGIN_PASSWORD)).thenReturn("test-token");
         when(propertyHelper.getAsString(KnownProperties.ORIGIN_ASTRA_DATABASE_ID)).thenReturn(null);
 
         // Test
-        String result = client.downloadSecureBundle(PKFactory.Side.ORIGIN);
+        assertThrows(Exception.class, () -> client.downloadSecureBundle(PKFactory.Side.ORIGIN));
 
         // Verify
-        assertNull(result);
         verify(propertyHelper).getAsString(KnownProperties.CONNECT_ORIGIN_PASSWORD);
         verify(propertyHelper).getAsString(KnownProperties.ORIGIN_ASTRA_DATABASE_ID);
     }
@@ -527,10 +523,7 @@ void testDownloadSecureBundleWithEmptyJsonResponse() throws Exception {
         when(propertyHelper.getAsString(KnownProperties.ORIGIN_ASTRA_SCB_REGION)).thenReturn(null);
 
         // Test
-        String result = client.downloadSecureBundle(PKFactory.Side.ORIGIN);
-
-        // Verify
-        assertNull(result);
+        assertThrows(Exception.class, () -> client.downloadSecureBundle(PKFactory.Side.ORIGIN));
     }
 
     @Test