Skip to content

Commit e5d0832

Browse files
Pull request review - corrections
1 parent 4882ffe commit e5d0832

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/main/java/datastax/cdm/job/DiffJobSession.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import datastax.cdm.cql.statement.TargetSelectByPKStatement;
1515
import datastax.cdm.properties.ColumnsKeysTypes;
1616
import datastax.cdm.properties.KnownProperties;
17+
import org.apache.commons.lang.StringUtils;
1718
import org.apache.spark.SparkConf;
1819
import org.slf4j.Logger;
1920
import org.slf4j.LoggerFactory;
@@ -145,7 +146,7 @@ public void getDataAndDiff(BigInteger min, BigInteger max) {
145146
logger.error("Error occurred during Attempt#: {}", attempts, e);
146147
logger.error("Error with PartitionRange -- ThreadID: {} Processing min: {} max: {} -- Attempt# {}",
147148
Thread.currentThread().getId(), min, max, attempts);
148-
if (null != tokenRangeExceptionDir && tokenRangeExceptionDir.trim().length() > 0 && attempts == maxAttempts) {
149+
if (StringUtils.isNotBlank(tokenRangeExceptionDir) && attempts == maxAttempts) {
149150
logFailedPartitionsInFile(min, max);
150151
}
151152
}

src/main/java/datastax/cdm/job/SplitPartitions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ public static List<Partition> getFailedSubPartitionsFromFile(int splitSize, Stri
178178
rename.delete();
179179
}
180180
boolean flag = file.renameTo(rename);
181-
if (flag == true) {
181+
if (flag) {
182182
logger.info("File Successfully Renamed to : "+renamedFile);
183183
}
184184
else {

0 commit comments

Comments
 (0)