Skip to content

Commit f0c77c8

Browse files
committed
CDM-20 better isEnabled wrapper
1 parent 8bf62d2 commit f0c77c8

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

src/main/java/datastax/astra/migrate/cql/CqlHelper.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -457,4 +457,11 @@ private void abendIfSessionsNotSet() {
457457
public Feature getFeature(Featureset featureEnum) {
458458
return featureMap.get(featureEnum);
459459
}
460+
461+
public Boolean isFeatureEnabled(Featureset featureEnum) {
462+
if (!featureMap.containsKey(featureEnum)) {
463+
return false;
464+
}
465+
return featureMap.get(featureEnum).isEnabled();
466+
}
460467
}

src/test/java/datastax/astra/migrate/CqlHelperTest.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
package datastax.astra.migrate;
22

33
import datastax.astra.migrate.cql.CqlHelper;
4+
import datastax.astra.migrate.cql.features.Featureset;
45
import datastax.astra.migrate.properties.KnownProperties;
56
import datastax.astra.migrate.properties.PropertyHelper;
67
import org.apache.spark.SparkConf;
78
import org.junit.jupiter.api.AfterEach;
89
import org.junit.jupiter.api.BeforeEach;
910
import org.junit.jupiter.api.Test;
1011

11-
import static org.junit.jupiter.api.Assertions.assertAll;
12-
import static org.junit.jupiter.api.Assertions.assertEquals;
12+
import static org.junit.jupiter.api.Assertions.*;
1313

1414
public class CqlHelperTest {
1515

@@ -54,4 +54,10 @@ public void smokeTest() {
5454
);
5555
}
5656

57+
@Test
58+
public void featureHelper_disabledWhenNull() {
59+
propertyHelper.initializeSparkConf(sparkConf);
60+
cqlHelper.initialize();
61+
assertFalse(cqlHelper.isFeatureEnabled(Featureset.TEST_UNIMPLEMENTED_FEATURE));
62+
}
5763
}

0 commit comments

Comments
 (0)