Skip to content

Commit f0e719e

Browse files
committed
Fixed additional PR comments.
1 parent 6c04f3c commit f0e719e

File tree

3 files changed

+6
-25
lines changed

3 files changed

+6
-25
lines changed

pom.xml

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -48,21 +48,7 @@
4848
<artifactId>spark-sql_${scala.main.version}</artifactId>
4949
<version>${spark.version}</version>
5050
</dependency>
51-
<dependency>
52-
<groupId>org.apache.spark</groupId>
53-
<artifactId>spark-hive_${scala.main.version}</artifactId>
54-
<version>${spark.version}</version>
55-
<exclusions>
56-
<exclusion>
57-
<groupId>log4j</groupId>
58-
<artifactId>log4j</artifactId>
59-
</exclusion>
60-
<exclusion>
61-
<groupId>log4j</groupId>
62-
<artifactId>apache-log4j-extras</artifactId>
63-
</exclusion>
64-
</exclusions>
65-
</dependency>
51+
6652
<dependency>
6753
<groupId>com.datastax.spark</groupId>
6854
<artifactId>spark-cassandra-connector_${scala.main.version}</artifactId>
@@ -74,11 +60,6 @@
7460
<version>3.1.15</version>
7561
</dependency>
7662

77-
<dependency>
78-
<groupId>org.apache.logging.log4j</groupId>
79-
<artifactId>log4j-api</artifactId>
80-
<version>2.19.0</version>
81-
</dependency>
8263
<dependency>
8364
<groupId>org.apache.logging.log4j</groupId>
8465
<artifactId>log4j-core</artifactId>

src/main/java/datastax/astra/migrate/AbstractJobSession.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import datastax.astra.migrate.schema.ColumnInfo;
99
import datastax.astra.migrate.schema.TableInfo;
1010
import datastax.astra.migrate.schema.TypeInfo;
11-
import org.apache.commons.lang.StringUtils;
11+
import org.apache.commons.lang3.StringUtils;
1212
import org.apache.spark.SparkConf;
1313
import org.slf4j.Logger;
1414
import org.slf4j.LoggerFactory;
@@ -91,19 +91,19 @@ protected AbstractJobSession(CqlSession sourceSession, CqlSession astraSession,
9191
}
9292
String maxWriteTimeStampFilterStr =
9393
Util.getSparkPropOr(sc, "spark.origin.maxWriteTimeStampFilter", "0");
94-
if (null != maxWriteTimeStampFilterStr && maxWriteTimeStampFilterStr.trim().length() > 1) {
94+
if (StringUtils.isNotBlank(maxWriteTimeStampFilterStr)) {
9595
maxWriteTimeStampFilter = Long.parseLong(maxWriteTimeStampFilterStr);
9696
}
9797

9898
String customWriteTimeStr =
9999
Util.getSparkPropOr(sc, "spark.target.writeTime.fixedValue", "0");
100-
if (null != customWriteTimeStr && customWriteTimeStr.trim().length() > 0 && StringUtils.isNumeric(customWriteTimeStr.trim())) {
100+
if (StringUtils.isNotBlank(customWriteTimeStr) && StringUtils.isNumeric(customWriteTimeStr.trim())) {
101101
customWriteTime = Long.parseLong(customWriteTimeStr);
102102
}
103103

104104
String incrWriteTimeStr =
105105
Util.getSparkPropOr(sc, "spark.target.writeTime.incrementBy", "0");
106-
if (null != incrWriteTimeStr && incrWriteTimeStr.trim().length() > 0 && StringUtils.isNumeric(incrWriteTimeStr.trim())) {
106+
if (StringUtils.isNotBlank(incrWriteTimeStr) && StringUtils.isNumeric(incrWriteTimeStr.trim())) {
107107
incrementWriteTime = Long.parseLong(incrWriteTimeStr);
108108
}
109109

src/main/java/datastax/astra/migrate/Util.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package datastax.astra.migrate;
22

33
import com.datastax.oss.driver.api.core.ConsistencyLevel;
4-
import org.apache.commons.lang.StringUtils;
4+
import org.apache.commons.lang3.StringUtils;
55
import org.apache.spark.SparkConf;
66

77
import java.io.BufferedReader;

0 commit comments

Comments
 (0)