Skip to content

Commit 9a82b02

Browse files
authored
Bulk upgrade of Quarkus and the Cassandra driver (#213)
1 parent 590377e commit 9a82b02

File tree

25 files changed

+133
-84
lines changed

25 files changed

+133
-84
lines changed

bom/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
<dependency>
7070
<groupId>org.apache.tinkerpop</groupId>
7171
<artifactId>gremlin-core</artifactId>
72-
<version>3.4.10</version>
72+
<version>3.5.3</version>
7373
<optional>true</optional>
7474
<exclusions>
7575
<exclusion>
@@ -93,7 +93,7 @@
9393
<dependency>
9494
<groupId>org.apache.tinkerpop</groupId>
9595
<artifactId>tinkergraph-gremlin</artifactId>
96-
<version>3.4.10</version>
96+
<version>3.5.3</version>
9797
<optional>true</optional>
9898
</dependency>
9999
<dependency>

changelog/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
### 1.1.3 (in progress)
2+
3+
This release is built against Quarkus 2.15.0.Final and the Cassandra driver 4.15.0.
4+
15
### 1.1.2
26

37
This release is built against Quarkus 2.7.1.Final and the Cassandra driver 4.14.0.

deployment/src/test/java/com/datastax/oss/quarkus/deployment/internal/health/CassandraHealthCheckBuildItemDisabledTest.java

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,24 @@
1616
package com.datastax.oss.quarkus.deployment.internal.health;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19+
import static org.assertj.core.api.Assertions.assertThatThrownBy;
1920

2021
import com.datastax.oss.quarkus.runtime.internal.health.CassandraAsyncHealthCheck;
2122
import com.datastax.oss.quarkus.test.CassandraTestResource;
22-
import io.quarkus.arc.Arc;
2323
import io.quarkus.test.QuarkusUnitTest;
24-
import java.util.Set;
25-
import javax.enterprise.inject.spi.Bean;
24+
import javax.enterprise.inject.UnsatisfiedResolutionException;
25+
import javax.inject.Inject;
26+
import javax.inject.Provider;
27+
import org.eclipse.microprofile.health.Readiness;
2628
import org.jboss.shrinkwrap.api.ShrinkWrap;
2729
import org.jboss.shrinkwrap.api.spec.JavaArchive;
2830
import org.junit.jupiter.api.Test;
2931
import org.junit.jupiter.api.extension.RegisterExtension;
3032

3133
public class CassandraHealthCheckBuildItemDisabledTest {
34+
35+
@Inject @Readiness Provider<CassandraAsyncHealthCheck> healthCheckProvider;
36+
3237
@RegisterExtension
3338
static QuarkusUnitTest runner =
3439
new QuarkusUnitTest()
@@ -38,7 +43,9 @@ public class CassandraHealthCheckBuildItemDisabledTest {
3843

3944
@Test
4045
public void should_not_have_health_check_in_the_container() {
41-
Set<Bean<?>> beans = Arc.container().beanManager().getBeans(CassandraAsyncHealthCheck.class);
42-
assertThat(beans.size()).isZero();
46+
assertThat(healthCheckProvider).isNotNull();
47+
assertThatThrownBy(healthCheckProvider::get)
48+
.isInstanceOf(UnsatisfiedResolutionException.class)
49+
.hasMessageContaining("No bean found for required type");
4350
}
4451
}

deployment/src/test/java/com/datastax/oss/quarkus/deployment/internal/health/CassandraHealthCheckBuildItemEnabledTest.java

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,20 @@
1919

2020
import com.datastax.oss.quarkus.runtime.internal.health.CassandraAsyncHealthCheck;
2121
import com.datastax.oss.quarkus.test.CassandraTestResource;
22-
import io.quarkus.arc.Arc;
2322
import io.quarkus.test.QuarkusUnitTest;
24-
import java.util.Set;
25-
import javax.enterprise.inject.spi.Bean;
23+
import java.util.concurrent.ExecutionException;
24+
import javax.inject.Inject;
25+
import org.eclipse.microprofile.health.HealthCheckResponse;
26+
import org.eclipse.microprofile.health.Readiness;
2627
import org.jboss.shrinkwrap.api.ShrinkWrap;
2728
import org.jboss.shrinkwrap.api.spec.JavaArchive;
2829
import org.junit.jupiter.api.Test;
2930
import org.junit.jupiter.api.extension.RegisterExtension;
3031

3132
public class CassandraHealthCheckBuildItemEnabledTest {
33+
34+
@Inject @Readiness CassandraAsyncHealthCheck healthCheck;
35+
3236
@RegisterExtension
3337
static QuarkusUnitTest runner =
3438
new QuarkusUnitTest()
@@ -37,8 +41,15 @@ public class CassandraHealthCheckBuildItemEnabledTest {
3741
.overrideConfigKey("quarkus.cassandra.health.enabled", "true");
3842

3943
@Test
40-
public void should_have_health_check_in_the_container() {
41-
Set<Bean<?>> beans = Arc.container().beanManager().getBeans(CassandraAsyncHealthCheck.class);
42-
assertThat(beans.size()).isEqualTo(1);
44+
public void should_have_health_check_in_the_container()
45+
throws ExecutionException, InterruptedException {
46+
assertThat(healthCheck).isNotNull();
47+
assertThat(healthCheck.call().subscribe().asCompletionStage().get())
48+
.isNotNull()
49+
.satisfies(
50+
hc -> {
51+
assertThat(hc.getName()).isEqualTo("DataStax Apache Cassandra Driver health check");
52+
assertThat(hc.getStatus()).isEqualTo(HealthCheckResponse.Status.UP);
53+
});
4354
}
4455
}

integration-tests/application/src/main/java/com/datastax/oss/quarkus/tests/dao/ProductReactiveQueries.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ public ProductReactiveQueries(MapperContext context, EntityHelper<Product> produ
4646
public Multi<Product> queryProviderSelectMultiProduct() {
4747
return MutinyWrappers.toMulti(
4848
new DefaultMappedReactiveResultSet<>(
49-
session.executeReactive("SELECT * FROM product"), productHelper::get));
49+
session.executeReactive("SELECT * FROM product"),
50+
source -> productHelper.get(source, false)));
5051
}
5152

5253
public Uni<Product> queryProviderSelectUniProduct(UUID id) {
@@ -63,7 +64,8 @@ public MutinyReactiveResultSet queryProviderSelectResultSet() {
6364
public MutinyMappedReactiveResultSet<Product> queryProviderSelectMappedResultSet() {
6465
return new DefaultMutinyMappedReactiveResultSet<>(
6566
new DefaultMappedReactiveResultSet<>(
66-
session.executeReactive("SELECT * FROM product"), productHelper::get));
67+
session.executeReactive("SELECT * FROM product"),
68+
source -> productHelper.get(source, false)));
6769
}
6870

6971
public Multi<Row> queryProviderSelectMultiRow() {

integration-tests/application/src/main/java/com/datastax/oss/quarkus/tests/resource/ProductReactiveResource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class ProductReactiveResource {
3737
consumes = MediaType.APPLICATION_JSON,
3838
order = 1)
3939
public void createProduct(RoutingExchange ex) {
40-
Product product = Json.decodeValue(ex.context().getBody(), Product.class);
40+
Product product = Json.decodeValue(ex.context().body().asString(), Product.class);
4141
service
4242
.create(product)
4343
.subscribe()
@@ -51,7 +51,7 @@ public void createProduct(RoutingExchange ex) {
5151
order = 1)
5252
public void updateProduct(RoutingExchange ex) {
5353
UUID id = ex.getParam("id").map(UUID::fromString).orElseThrow(IllegalStateException::new);
54-
Product product = Json.decodeValue(ex.context().getBody(), Product.class);
54+
Product product = Json.decodeValue(ex.context().body().asString(), Product.class);
5555
product.setId(id);
5656
service
5757
.update(product)

integration-tests/dse/src/test/java/com/datastax/oss/quarkus/tests/DseTestBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
initArgs = {
2525
@ResourceArg(
2626
name = "quarkus.cassandra.test.container.image",
27-
value = "datastax/dse-server:6.8.14"),
27+
value = "datastax/dse-server:6.8.25"),
2828
// activate DSE Graph with the -g switch; the resulting command will be: dse cassandra -f -g
2929
@ResourceArg(name = "quarkus.cassandra.test.container.cmd", value = "-g"),
3030
@ResourceArg(name = "quarkus.cassandra.test.container.startup-timeout", value = "PT5M")

integration-tests/main/src/test/java/com/datastax/oss/quarkus/tests/nativ/CassandraHealthCheckNativeIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
package com.datastax.oss.quarkus.tests.nativ;
1717

1818
import com.datastax.oss.quarkus.tests.CassandraHealthCheckIT;
19-
import io.quarkus.test.junit.NativeImageTest;
19+
import io.quarkus.test.junit.QuarkusIntegrationTest;
2020
import org.junit.jupiter.api.Tag;
2121

22-
@NativeImageTest
22+
@QuarkusIntegrationTest
2323
@Tag("native")
2424
public class CassandraHealthCheckNativeIT extends CassandraHealthCheckIT {}

integration-tests/main/src/test/java/com/datastax/oss/quarkus/tests/nativ/CassandraMetricsNativeIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
package com.datastax.oss.quarkus.tests.nativ;
1717

1818
import com.datastax.oss.quarkus.tests.CassandraMetricsIT;
19-
import io.quarkus.test.junit.NativeImageTest;
19+
import io.quarkus.test.junit.QuarkusIntegrationTest;
2020
import org.junit.jupiter.api.Tag;
2121

22-
@NativeImageTest
22+
@QuarkusIntegrationTest
2323
@Tag("native")
2424
public class CassandraMetricsNativeIT extends CassandraMetricsIT {}

integration-tests/main/src/test/java/com/datastax/oss/quarkus/tests/nativ/CustomerResourceNativeIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
package com.datastax.oss.quarkus.tests.nativ;
1717

1818
import com.datastax.oss.quarkus.tests.CustomerResourceIT;
19-
import io.quarkus.test.junit.NativeImageTest;
19+
import io.quarkus.test.junit.QuarkusIntegrationTest;
2020
import org.junit.jupiter.api.Tag;
2121

22-
@NativeImageTest
22+
@QuarkusIntegrationTest
2323
@Tag("native")
2424
public class CustomerResourceNativeIT extends CustomerResourceIT {}

0 commit comments

Comments
 (0)