Ninja: Removed ThreadLocalRandom usage in ANNOptionsDistributedTest, as causing test flakiness.

sbtourist · sbtourist · commit 6de8ee18fe95 · 2025-03-17T14:27:11.000Z
diff --git a/test/distributed/org/apache/cassandra/distributed/test/sai/ANNOptionsDistributedTest.java b/test/distributed/org/apache/cassandra/distributed/test/sai/ANNOptionsDistributedTest.java
@@ -16,8 +16,6 @@
 
 package org.apache.cassandra.distributed.test.sai;
 
-import java.util.concurrent.ThreadLocalRandom;
-
 import org.junit.Test;
 
 import net.bytebuddy.ByteBuddy;
@@ -120,8 +118,7 @@ public static class BB
     {
         public static void install(ClassLoader classLoader, int node)
         {
-            // inject randomly first or second node to make sure it works if the node is a coordinator or replica
-            if (node == ThreadLocalRandom.current().nextInt(1, 3))
+            if (node == 1)
             {
                 new ByteBuddy().rebase(MessagingService.class)
                                .method(named("currentVersion"))

Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,6 @@`
`16`	`16`
`17`	`17`	`package org.apache.cassandra.distributed.test.sai;`
`18`	`18`
`19`		`-import java.util.concurrent.ThreadLocalRandom;`
`20`		`-`
`21`	`19`	`import org.junit.Test;`
`22`	`20`
`23`	`21`	`import net.bytebuddy.ByteBuddy;`
`@@ -120,8 +118,7 @@ public static class BB`
`120`	`118`	`{`
`121`	`119`	`public static void install(ClassLoader classLoader, int node)`
`122`	`120`	`{`
`123`		`- // inject randomly first or second node to make sure it works if the node is a coordinator or replica`
`124`		`- if (node == ThreadLocalRandom.current().nextInt(1, 3))`
	`121`	`+ if (node == 1)`
`125`	`122`	`{`
`126`	`123`	`new ByteBuddy().rebase(MessagingService.class)`
`127`	`124`	`.method(named("currentVersion"))`