Cleanup after code review

Author: michaeljmarshall

src/java/org/apache/cassandra/index/sai/disk/v5/V5VectorPostingsWriter.java

@@ -480,8 +480,8 @@ public static <T> RemappedPostings createGenericIdentityMapping(Map<VectorFloat<
                 maxRow = max(maxRow, rowId);
         }
 
-        assert maxOldOrdinal >= 0;
-        assert maxRow >= 0;
+        if (maxOldOrdinal < 0 || maxRow < 0)
+            throw new IllegalStateException("maxOldOrdinal or maxRow is negative: " + maxOldOrdinal + ' ' + maxRow);
 
         var presentOrdinals = new FixedBitSet(maxOldOrdinal + 1);
         for (var entry : postingsMap.entrySet())

src/java/org/apache/cassandra/index/sai/disk/vector/CompactionGraph.java

@@ -495,7 +495,7 @@ static <T> boolean safePut(ChronicleMap<T, CompactionVectorPostings> map, T key,
         }
         catch (IllegalArgumentException e)
         {
-            logger.error("Error serializing postings to disk, will reattempt with compression", e);
+            logger.debug("Error serializing postings to disk, will reattempt with compression", e);
             // This is an extreme edge case where there are many duplicate vectors. This naive approach
             // means that we might have a smaller vector graph than desired, but at least we will not
             // fail to build the index.

src/java/org/apache/cassandra/index/sai/disk/vector/VectorPostings.java

@@ -222,8 +222,9 @@ public void write(Bytes out, CompactionVectorPostings postings) {
                     for (int posting : postings.getPostings())
                         writer.writeVInt(posting);
                 }
-                catch (Exception e)
+                catch (IOException e)
                 {
+                    // Not be reachable because the Bytes out object does not throw an exception on write.
                     throw new RuntimeException(e);
                 }
             }
@@ -251,8 +252,9 @@ public CompactionVectorPostings read(Bytes in, CompactionVectorPostings using) {
 
                     return new CompactionVectorPostings(ordinal, postingsList);
                 }
-                catch (Exception e)
+                catch (IOException e)
                 {
+                    // Not be reachable because the Bytes in object does not throw an exception on read.
                     throw new RuntimeException(e);
                 }
             }
@@ -283,13 +285,13 @@ public BytesDataOutput(Bytes<?> bytes)
             }
 
             @Override
-            public void writeByte(byte b) throws IOException
+            public void writeByte(byte b)
             {
                 bytes.writeByte(b);
             }
 
             @Override
-            public void writeBytes(byte[] b, int off, int len) throws IOException
+            public void writeBytes(byte[] b, int off, int len)
             {
                 bytes.write(b, off, len);
             }
@@ -305,7 +307,7 @@ public BytesDataInput(Bytes<?> bytes)
             }
 
             @Override
-            public byte readByte() throws IOException
+            public byte readByte()
             {
                 return bytes.readByte();
             }

test/unit/org/apache/cassandra/index/sai/disk/vector/CompactionGraphTest.java

@@ -55,7 +55,7 @@ public void test50MEntries() throws Exception
         testEntries(50000000, 5000, 100);
     }
 
-    // Callers of this method are expected to provide enought iterations and postings added per iteration
+    // Callers of this method are expected to provide enough iterations and postings added per iteration
     // to hit the entry size limit without exceeding it too much. Note that we add postings one at a time in the
     // compaction graph, so we only ever increment by 4 bytes each time we attempt to re-serialize the entry.
     private void testEntries(int entries, int iterations, int postingsAddedPerIteration) throws Exception