StringToVectorCodecTest.should_fail_to_encode_too_many_or_too_few:111 » IllegalArgument fix

Author: Madhavan

codecs/text/src/test/java/com/datastax/oss/dsbulk/codecs/text/string/StringToVectorCodecTest.java

@@ -92,10 +92,10 @@ void should_not_convert_from_invalid_external() {
     assertThat(codec).cannotConvertFromExternal("[6.646329843]");
   }
 
-  // To keep usage consistent with VectorCodec we confirm that we support encoding when too many
-  // elements are available but not when too few are.  Note that it's actually VectorCodec that
-  // enforces this constraint so we have to go through encode() rather than the internal/external
-  // methods.
+  // VectorCodec enforces strict dimension matching: encoding fails for both too-many and too-few
+  // elements.  We have to go through encode() rather than the internal/external methods because
+  // the dimension check is performed by VectorCodec during binary encoding, not during
+  // String-to-CqlVector conversion.
   @Test
   void should_fail_to_encode_too_many_or_too_few() {
 
@@ -108,7 +108,8 @@ void should_fail_to_encode_too_many_or_too_few() {
     CqlVector<Float> tooFewVector = CqlVector.newInstance(tooFew);
     String tooFewString = codec.internalToExternal(tooFewVector);
 
-    assertThat(codec.encode(tooManyString, ProtocolVersion.DEFAULT)).isNotNull();
+    assertThatThrownBy(() -> codec.encode(tooManyString, ProtocolVersion.DEFAULT))
+        .isInstanceOf(IllegalArgumentException.class);
     assertThatThrownBy(() -> codec.encode(tooFewString, ProtocolVersion.DEFAULT))
         .isInstanceOf(IllegalArgumentException.class);
   }