Fix FusedADC.writeInline (#417)

marianotepper · web-flow · commit 06ac8aa088d1 · 2025-04-07T12:24:40.000-07:00
diff --git a/jvector-base/src/main/java/io/github/jbellis/jvector/graph/disk/feature/FusedADC.java b/jvector-base/src/main/java/io/github/jbellis/jvector/graph/disk/feature/FusedADC.java
@@ -105,13 +105,13 @@ public void writeInline(DataOutput out, Feature.State state_) throws IOException
 
         var neighbors = state.view.getNeighborsIterator(0, state.nodeId); // TODO
         int n = 0;
-        var neighborSize = neighbors.size();
         compressedNeighbors.zero();
-        for (; n < neighborSize; n++) {
+        while (neighbors.hasNext()) {
             var compressed = pqv.get(neighbors.nextInt());
             for (int j = 0; j < pqv.getCompressedSize(); j++) {
                 compressedNeighbors.set(j * maxDegree + n, compressed.get(j));
             }
+            n++;
         }
 
         vectorTypeSupport.writeByteSequence(out, compressedNeighbors);

Original file line number	Diff line number	Diff line change
`@@ -105,13 +105,13 @@ public void writeInline(DataOutput out, Feature.State state_) throws IOException`
`105`	`105`
`106`	`106`	`var neighbors = state.view.getNeighborsIterator(0, state.nodeId); // TODO`
`107`	`107`	`int n = 0;`
`108`		`- var neighborSize = neighbors.size();`
`109`	`108`	`compressedNeighbors.zero();`
`110`		`- for (; n < neighborSize; n++) {`
	`109`	`+ while (neighbors.hasNext()) {`
`111`	`110`	`var compressed = pqv.get(neighbors.nextInt());`
`112`	`111`	`for (int j = 0; j < pqv.getCompressedSize(); j++) {`
`113`	`112`	`compressedNeighbors.set(j * maxDegree + n, compressed.get(j));`
`114`	`113`	`}`
	`114`	`+ n++;`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`vectorTypeSupport.writeByteSequence(out, compressedNeighbors);`