Add ruff rules for blind-except (#564)

Author: cbornet

examples/evaluation/tru_shared.py

@@ -1,4 +1,5 @@
 import json
+import logging
 import os
 import uuid
 from enum import Enum
@@ -28,6 +29,7 @@
 load_dotenv()
 
 temperature = 0
+logger = logging.getLogger(__name__)
 
 
 class Framework(Enum):
@@ -223,4 +225,6 @@ def execute_experiment(framework: Framework, pipeline, experiment_name: str):
                 with tru_recorder:
                     execute_query(framework, pipeline, query)
             except Exception:
-                print(f"Query: '{query}' caused exception, skipping.")
+                err = f"Query: '{query}' caused exception, skipping."
+                logger.exception(err)
+                print(err)

examples/notebooks/langchain_multimodal_gemini.ipynb

@@ -627,7 +627,7 @@
     "                \"$vector\": embeddings.image_embedding,\n",
     "            }\n",
     "        )\n",
-    "    except Exception as error:\n",
+    "    except Exception as error:  # noqa: BLE001\n",
     "        # if you've already added this record, skip the error message\n",
     "        error_info = json.loads(str(error))\n",
     "        if error_info[0][\"errorCode\"] == \"DOCUMENT_ALREADY_EXISTS\":\n",

libs/colbert/ragstack_colbert/cassandra_database.py

@@ -91,7 +91,7 @@ def _initialize(
 
         try:
             is_astra = session.cluster.cloud
-        except Exception:
+        except AttributeError:
             is_astra = False
 
         logging.info(
@@ -147,7 +147,7 @@ def add_chunks(self, chunks: List[Chunk]) -> List[Tuple[str, int]]:
                     body_blob=chunk.text,
                     metadata=chunk.metadata,
                 )
-            except Exception as exp:
+            except Exception as exp:  # noqa: BLE001
                 self._log_insert_error(
                     doc_id=doc_id, chunk_id=chunk_id, embedding_id=-1, exp=exp
                 )
@@ -161,7 +161,7 @@ def add_chunks(self, chunks: List[Chunk]) -> List[Tuple[str, int]]:
                         row_id=(chunk_id, embedding_id),
                         vector=vector,
                     )
-                except Exception as exp:
+                except Exception as exp:  # noqa: BLE001
                     self._log_insert_error(
                         doc_id=doc_id, chunk_id=chunk_id, embedding_id=-1, exp=exp
                     )
@@ -202,7 +202,7 @@ async def _limited_put(
                     await self._table.aput(
                         partition_id=doc_id, row_id=row_id, vector=vector
                     )
-            except Exception as e:
+            except Exception as e:  # noqa: BLE001
                 return doc_id, chunk_id, embedding_id, e
             return doc_id, chunk_id, embedding_id, None
 
@@ -317,7 +317,7 @@ async def _limited_delete(
         async with sem:
             try:
                 await self._table.adelete_partition(partition_id=doc_id)
-            except Exception as e:
+            except Exception as e:  # noqa: BLE001
                 return doc_id, e
             return doc_id, None
 

libs/e2e-tests/e2e_tests/conftest.py

@@ -133,16 +133,16 @@ def pytest_runtest_makereport(item, call):
                 failed_report_lines.append(report_line)
                 if call.excinfo:
                     try:
-                        logging.warn("Full stacktrace:")
+                        logging.warning("Full stacktrace:")
                         import traceback
 
                         traceback.print_exception(
                             call.excinfo._excinfo[0],
                             call.excinfo._excinfo[1],
                             call.excinfo._excinfo[2],
                         )
-                    except Exception as e:
-                        logging.warn(f"Failed to print stacktrace: {e}")
+                    except Exception:  # noqa: BLE001
+                        logging.warning("Failed to print stacktrace", exc_info=True)
             all_report_lines.append(report_line)
             if is_langchain:
                 langchain_report_lines.append(report_line)

libs/ragulate/ragstack_ragulate/pipelines/base_pipeline.py

@@ -1,13 +1,11 @@
 import importlib.util
 import inspect
-import traceback
+import logging
 from abc import ABC, abstractmethod
 from typing import Any, Dict, List
 
 from ragstack_ragulate.datasets import BaseDataset
 
-from ..logging_config import logger
-
 
 # Function to dynamically load a module
 def load_module(file_path, name):
@@ -92,13 +90,13 @@ def __init__(
                 reserved_params=self.get_reserved_params,
                 passed_ingredients=self._passed_ingredients,
             )
-        except BaseException as e:
-            logger.fatal(
+        except BaseException:  # noqa: BLE001
+            logging.critical(
                 f"Issue loading recipe {self.recipe_name} "
                 f"on {self.script_path}/{self.method_name} "
-                f"with passed ingredients: {self._passed_ingredients}: {e}"
+                f"with passed ingredients: {self._passed_ingredients}",
+                exc_info=True,
             )
-            traceback.print_exc()
             exit(1)
 
     def get_method(self):

libs/ragulate/ragstack_ragulate/pipelines/query_pipeline.py

@@ -125,8 +125,8 @@ def stop_evaluation(self, loc: str):
                 self._tru.stop_evaluator()
                 self._evaluation_running = False
                 self._tru.delete_singleton()
-            except Exception as e:
-                logger.error(f"issue stopping evaluator: {e}")
+            except Exception:  # noqa: BLE001
+                logger.exception("issue stopping evaluator")
             finally:
                 self._progress.close()
 
@@ -218,13 +218,11 @@ def query(self):
                 try:
                     with recorder:
                         pipeline.invoke(query)
-                except Exception as e:
+                except Exception as e:  # noqa: BLE001
+                    err = f"Query: '{query}' caused exception, skipping."
+                    logger.exception(err)
                     # TODO: figure out why the logger isn't working after tru-lens starts. For now use print().  # noqa: E501
-                    print(
-                        f"ERROR: Query: '{query}' caused exception, skipping. "
-                        f"Exception {e}"
-                    )
-                    logger.error(f"Query: '{query}' caused exception: {e}, skipping.")
+                    print(f"{err} Exception {e}")
                 finally:
                     self.update_progress(query_change=1)
 

pyproject.toml

@@ -69,6 +69,7 @@ ignore = [
 select = [
     "ASYNC",
     "B",
+    "BLE",
     "C4",
     "COM",
     "DTZ",