fix #27 handle empty array during scale calc

sgratzl · sgratzl · commit 19fb4bc59dc7 · 2019-01-16T10:25:54.000+01:00
diff --git a/samples/empty.html b/samples/empty.html
@@ -0,0 +1,69 @@
+<!doctype html>
+<html>
+
+<head>
+  <title>Box Plot Chart</title>
+  <script src="../node_modules/chart.js/dist/Chart.bundle.js"></script>
+  <script src="../build/Chart.BoxPlot.js" type="text/javascript"></script>
+  <style>
+  canvas {
+    -moz-user-select: none;
+    -webkit-user-select: none;
+    -ms-user-select: none;
+  }
+  </style>
+</head>
+
+<body>
+  <div id="container" style="width: 75%;">
+    <canvas id="canvas"></canvas>
+  </div>
+  <script>
+    function randomValues(count, min, max) {
+      const delta = max - min;
+      return Array.from({length: count}).map(() => Math.random() * delta + min);
+    }
+    const boxplotData = {
+      labels: ['A', 'B'],
+      datasets: [{
+        label: 'Dataset 1',
+        borderColor: 'red',
+        borderWidth: 1,
+        outlierRadius: 3,
+        itemRadius: 3,
+        outlierColor: '#999999',
+        data: [
+          [],
+          randomValues(100, 0, 10)
+        ],
+      }]
+    };
+
+    window.onload = function() {
+      var ctx = document.getElementById("canvas").getContext("2d");
+      window.myBar = new Chart(ctx, {
+        type: 'boxplot',
+        data: boxplotData,
+        options: {
+          responsive: true,
+          legend: {
+            position: 'top',
+          },
+          title: {
+            display: true,
+            text: 'Chart.js Box Plot Chart'
+          },
+          scales: {
+            xAxes: [{
+              // Specific to Bar Controller
+              categoryPercentage: 0.9,
+              barPercentage: 0.8
+            }]
+          }
+        }
+      });
+    };
+  </script>
+</body>
+
+</html>
diff --git a/src/data.js b/src/data.js
@@ -139,7 +139,7 @@ export function asValueStats(value, minStats, maxStats) {
   if (typeof value[minStats] === 'number' && typeof value[maxStats] === 'number') {
     return value;
   }
-  if (!Array.isArray(value)) {
+  if (!Array.isArray(value) || value.length === 0) {
     return undefined;
   }
   return asBoxPlotStats(value);

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ export function asValueStats(value, minStats, maxStats) {`
`139`	`139`	`if (typeof value[minStats] === 'number' && typeof value[maxStats] === 'number') {`
`140`	`140`	`return value;`
`141`	`141`	`}`
`142`		`- if (!Array.isArray(value)) {`
	`142`	`+ if (!Array.isArray(value) \|\| value.length === 0) {`
`143`	`143`	`return undefined;`
`144`	`144`	`}`
`145`	`145`	`return asBoxPlotStats(value);`