Skip to content

Commit 24e8f2d

Browse files
Merge branch 'main' into feat-automate-releases-releasenotes
2 parents 5d8c138 + de1f5f0 commit 24e8f2d

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

.github/actions/build-node-python/action.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,8 @@ runs:
247247
# Chromatic
248248
- name: Run Chromatic
249249
if: inputs.enable_node == 'true' && inputs.chromatic_enable == 'true'
250-
uses: chromaui/action@v11.5.4
250+
uses: chromaui/action@v11.7.1
251251
with:
252+
exitZeroOnChanges: true
253+
exitOnceUploaded: true
252254
projectToken: ${{ inputs.chromatic_project_token }}

.github/workflows/build-node-python.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ jobs:
375375
run_playwright_browser_install: true
376376
enable_node_cache: ${{ inputs.playwright_runs_on != 'self-hosted' && inputs.runs_on != 'self-hosted' }}
377377
enable_python_cache: ${{ inputs.playwright_runs_on != 'self-hosted' && inputs.runs_on != 'self-hosted' }}
378-
chromatic_enable: ${{ inputs.chromatic_enable }}
378+
chromatic_enable: false # Set to false as we run chromatic below w/ playwright integration
379379
chromatic_project_token: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
380380
- name: Decrypt .env.enc and <app>/.env.enc
381381
run: |
@@ -389,9 +389,23 @@ jobs:
389389
- name: Run playwright e2e tests
390390
run: yarn run pw:run ${{ inputs.playwright_spec_param }}
391391
shell: bash
392+
- name: Upload bundle
393+
uses: actions/upload-artifact@v4
394+
if: always()
395+
with:
396+
name: "bundles-${{ inputs.branch }}"
397+
path: bundles/
392398
- name: Upload playwright report
393399
uses: actions/upload-artifact@v4
394400
if: always()
395401
with:
396402
name: "playwright-report-${{ inputs.branch }}"
397403
path: playwright-report/
404+
- name: Run Chromatic Playwright
405+
if: ${{ inputs.chromatic_enable }}
406+
uses: chromaui/[email protected]
407+
with:
408+
playwright: true
409+
exitZeroOnChanges: true
410+
exitOnceUploaded: true
411+
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}

0 commit comments

Comments
 (0)