Cleanup pypi_registry

Author: puehringer

.github/actions/build-node-python/action.yml

@@ -101,9 +101,8 @@ runs:
   steps:
     # Node
     - uses: ./tmp/github-workflows/.github/actions/get-node-version
-      if: inputs.enable_node == 'true'
+      if: inputs.enable_node == 'true' && inputs.node_version == ''
       id: get-node-version
-
     - name: Set up node version
       uses: actions/setup-node@v5
       if: inputs.enable_node == 'true'

.github/actions/get-node-version/action.yml

@@ -25,10 +25,12 @@ runs:
           const fs = require('fs');
           // Load the sandboxed semver dependency from the action's own node_modules
           const semver = require(path.join(process.env.GITHUB_ACTION_PATH, 'node_modules/semver'));
+
+          const defaultVersion = '20.9';
           
           // Define the versions to check against the package.json engines field, in order of preference
           // See https://github.com/actions/node-versions/releases for available versions
-          const versionsToCheck = ['20.9', '24.9'].map((v) => semver.minVersion(v).version);
+          const versionsToCheck = [defaultVersion, '24.9'].map((v) => semver.minVersion(v).version);
 
           const packageJsonPath = path.join(process.env.GITHUB_WORKSPACE, 'package.json');
           if (!fs.existsSync(packageJsonPath)) {
@@ -40,8 +42,8 @@ runs:
           const requiredRange = packageJson.engines?.node;
 
           if (!requiredRange) {
-            core.info('No node engine requirement in package.json. Returning empty.');
-            return '';
+            core.info(`No node engine requirement in package.json. Returning default version ${defaultVersion}.`);
+            return defaultVersion;
           }
 
           core.info(`Required Node.js range: ${requiredRange}`);

.github/actions/publish-python/action.yml

@@ -5,15 +5,12 @@ author: datavisyn
 inputs:
   pypi_registry:
     description: "registry where to publish python package"
-    default: "https://upload.pypi.org/legacy/"
     required: false
   pypi_username:
     description: "username for python registry"
-    default: "admin"
     required: true
   pypi_password:
     description: "passwort for python registry"
-    default: "admin"
     required: true
 
 runs:
@@ -30,6 +27,6 @@ runs:
         twine upload dist_python/*
       shell: bash
       env:
-        PYPI_REPOSITORY: ${{ inputs.pypi_registry }}
+        PYPI_REPOSITORY: ${{ inputs.pypi_registry || 'https://upload.pypi.org/legacy/' }}
         TWINE_USERNAME: ${{ inputs.pypi_username }}
         TWINE_PASSWORD: ${{ inputs.pypi_password }}

.github/workflows/publish-node-python.yml

@@ -99,5 +99,6 @@ jobs:
           github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
       - uses: ./tmp/github-workflows/.github/actions/publish-python
         with:
+          pypi_registry: ${{ vars.PYPI_REGISTRY }}
           pypi_username: ${{ secrets.PYPI_USERNAME }}
           pypi_password: ${{ secrets.PYPI_PASSWORD }}

.github/workflows/publish-python.yml

@@ -56,5 +56,6 @@ jobs:
           github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
       - uses: ./tmp/github-workflows/.github/actions/publish-python
         with:
+          pypi_registry: ${{ vars.PYPI_REGISTRY }}
           pypi_username: ${{ secrets.PYPI_USERNAME }}
           pypi_password: ${{ secrets.PYPI_PASSWORD }}