Skip to content

Commit 350dcc0

Browse files
authored
feat: add UV_HTTP_TIMEOUT and fix yarn.lock upload (#227)
1 parent c7c9a7f commit 350dcc0

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

.github/actions/build-node-python/action.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@ inputs:
3333
required: false
3434
default: false
3535
upload_yarn_lock:
36-
description: "uploads the node-yarn-lock artifact"
36+
description: "name of the artifact to upload the node-yarn-lock artifact"
3737
required: false
38-
default: false # false as it is broken right now when actions run in parallel: the artifact name must be unique (so we have to pass the branch or so)
38+
default: ''
3939
upload_bundle:
40-
description: "uploads the bundle artifact"
40+
description: "name of the artifact to uploads the bundle artifact"
4141
required: false
42-
default: false # false as it is broken right now when actions run in parallel: the artifact name must be unique (so we have to pass the branch or so)
42+
default: ''
4343
run_node_lint:
4444
default: true
4545
required: false
@@ -271,6 +271,7 @@ runs:
271271
RUN_PYTHON_LINT: ${{ inputs.run_python_lint }}
272272
RUN_PYTHON_TEST: ${{ inputs.run_python_test }}
273273
RUN_PYTHON_BUILD: ${{ inputs.run_python_build }}
274+
UV_HTTP_TIMEOUT: 90 # https://docs.astral.sh/uv/reference/environment/#uv_http_timeout
274275
# Node
275276
- name: Save yarn cache
276277
uses: actions/cache/save@v4
@@ -280,14 +281,14 @@ runs:
280281
path: ~/.yarn/berry/cache/
281282
key: yarn-download-cache-${{ hashFiles('package.json') }}
282283
- uses: actions/upload-artifact@v4
283-
if: inputs.enable_node == 'true' && inputs.upload_yarn_lock == 'true'
284+
if: inputs.enable_node == 'true' && inputs.upload_yarn_lock
284285
with:
285-
name: node-yarn-lock
286+
name: ${{ inputs.upload_yarn_lock }}
286287
path: ./yarn.lock
287288
- uses: actions/upload-artifact@v4
288-
if: inputs.enable_node == 'true' && inputs.run_node_bundle == 'true' && inputs.upload_bundle == 'true'
289+
if: inputs.enable_node == 'true' && inputs.run_node_bundle == 'true' && inputs.upload_bundle
289290
with:
290-
name: node-bundle
291+
name: ${{ inputs.upload_bundle }}
291292
path: ./bundles
292293
# Chromatic
293294
- name: Run Chromatic

.github/workflows/build-docker-artifacts.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,7 @@ jobs:
228228
DATAVISYN_PYTHON_BASE_IMAGE=${{ env.DATAVISYN_PYTHON_BASE_IMAGE }}
229229
NODE_BASE_IMAGE=${{ env.NODE_BASE_IMAGE }}
230230
DATAVISYN_NGINX_BASE_IMAGE=${{ env.DATAVISYN_NGINX_BASE_IMAGE }}
231+
UV_HTTP_TIMEOUT=90
231232
${{ matrix.component.formatted_build_args }}
232233
secrets:
233234
# Mount the token as secret mount: https://docs.docker.com/build/ci/github-actions/secrets/#secret-mounts

.github/workflows/build-node-python.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ jobs:
170170
enable_python_cache: ${{ inputs.runs_on != 'self-hosted' }}
171171
chromatic_enable: ${{ inputs.chromatic_enable }}
172172
chromatic_project_token: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
173+
upload_yarn_lock: "node-yarn-lock-${{ inputs.branch || github.sha }}"
173174

174175
build-python:
175176
name: Python
@@ -445,6 +446,7 @@ jobs:
445446
enable_python_cache: ${{ inputs.playwright_runs_on != 'self-hosted' && inputs.runs_on != 'self-hosted' }}
446447
chromatic_enable: false # Set to false as we run chromatic below w/ playwright integration
447448
chromatic_project_token: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
449+
upload_yarn_lock: "node-yarn-lock-${{ inputs.branch || github.sha }}"
448450
- name: Decrypt .env.enc and <app>/.env.enc
449451
run: |
450452
yarn run env:decrypt -pass env:ENV_PASSWORD || true

0 commit comments

Comments
 (0)