fix: remove image scan by aws steps

Author: dv-hossam-radwan

.github/workflows/build-docker-artifacts.yml

@@ -249,7 +249,7 @@ jobs:
           ignore-unfixed: false
           vuln-type: 'os,library'
           severity: 'MEDIUM,HIGH,CRITICAL'
-        continue-on-error: true 
+        continue-on-error: false 
 
       - name: Push image
         uses: docker/build-push-action@v6
@@ -265,24 +265,6 @@ jobs:
         shell: bash
         run: docker logout ${{ steps.login-ecr.outputs.registry }}
 
-      - name: Scan image
-        if: ${{ inputs.skip_image_scan != true && fromJson(vars.SKIP_IMAGE_SCAN || 'false') != true && matrix.component.skip_image_scan != true }}
-        id: get-ecr-scan-result
-        uses: ./tmp/github-workflows/.github/actions/get-ecr-scan-result
-        with:
-          aws_role: ${{ vars.DV_AWS_ECR_ROLE }}
-          aws_region: ${{ vars.DV_AWS_REGION }}
-          ecr_registry: ${{ vars.DV_AWS_ECR_REGISTRY }}
-          ecr_repository: ${{ matrix.component.ecr_repository }}
-          image_tag: ${{ matrix.component.image_tag }}
-      - name: Check scan results
-        if: ${{ inputs.skip_image_scan != true && fromJson(vars.SKIP_IMAGE_SCAN || 'false') != true && matrix.component.skip_image_scan != true }}
-        run: |
-          if [ "${{ steps.get-ecr-scan-result.outputs.critical }}" != "null" ] || [ "${{ steps.get-ecr-scan-result.outputs.high }}" != "null" ]; then
-            echo "Docker image contains vulnerabilities at critical or high level"
-            #exit 1  #exit execution due to docker image vulnerabilities
-          fi
-
   retag-images:
     name: Retag images of flavor ${{ matrix.flavor || 'default' }}
     needs: [get-flavors, build-flavors]