feat: add smart get-node-version

Author: puehringer

.github/actions/build-node-python/action.yml

@@ -95,12 +95,18 @@ runs:
   using: "composite"
   steps:
     # Node
+    - uses: ./tmp/github-workflows/.github/actions/get-node-version
+      if: inputs.enable_node == 'true'
+      id: get-node-version
+
     - name: Set up node version
-      uses: actions/setup-node@v4
+      uses: actions/setup-node@v5
       if: inputs.enable_node == 'true'
       with:
-        node-version: ${{ inputs.node_version }}
+        # TODO: Revert the two
+        node-version: ${{ fromJson(steps.get-node-version.outputs.node_version) || inputs.node_version }}
         registry-url: ${{ inputs.npm_registry }}
+        package-manager-cache: false
     - name: Show node and npm version
       if: inputs.enable_node == 'true'
       run: |

.github/actions/get-node-version/action.yml

@@ -0,0 +1,57 @@
+name: get-node-version
+description: extracts the node version from the package.json engines
+author: datavisyn
+
+outputs:
+  node_version:
+    description: "extracted node version"
+    value: ${{ steps.get-node-version.outputs.result }}
+
+runs:
+  using: "composite"
+  steps:
+    - name: Setup sandboxed dependencies
+      shell: bash
+      run: |
+        npm init -y --prefix ${{ github.action_path }} >/dev/null 2>&1
+        npm install semver --prefix ${{ github.action_path }} >/dev/null 2>&1
+
+    - name: Find version script
+      id: get-node-version
+      uses: actions/github-script@v7
+      with:
+        script: |
+          const path = require('path');
+          const fs = require('fs');
+          // Load the sandboxed semver dependency from the action's own node_modules
+          const semver = require(path.join(process.env.GITHUB_ACTION_PATH, 'node_modules/semver'));
+          
+          // Define the versions to check against the package.json engines field, in order of preference
+          // See https://github.com/actions/node-versions/releases for available versions
+          const versionsToCheck = ['24.9', '20.9'].map((v) => semver.minVersion(v).version);
+
+          const packageJsonPath = path.join(process.env.GITHUB_WORKSPACE, 'package.json');
+          if (!fs.existsSync(packageJsonPath)) {
+            core.setFailed(`Error: package.json not found at ${packageJsonPath}`);
+            return;
+          }
+          
+          const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
+          const requiredRange = packageJson.engines?.node;
+
+          if (!requiredRange) {
+            core.info('No node engine requirement in package.json. Returning empty.');
+            return '';
+          }
+
+          core.info(`Required Node.js range: ${requiredRange}`);
+
+          for (const version of versionsToCheck) {
+            if (semver.satisfies(version, requiredRange)) {
+              core.info(`\nMatch found! Returning version ${version}.`);
+              // Simply return the matching version string to set the 'result' output
+              return version;
+            }
+          }
+
+          core.setFailed(`\nNo compatible Node.js version found in the list of versions "${versionsToCheck.join(', ')}" for range "${requiredRange}".`);

.github/workflows/build-node-python.yml

@@ -119,7 +119,7 @@ env:
   PYPI_REGISTRY: "https://upload.pypi.org/legacy/"
   PYPI_USERNAME: "datavisyn"
   PYTHON_VERSION: ${{ vars.PYTHON_VERSION || '3.10' }}
-  WORKFLOW_BRANCH: "main"
+  WORKFLOW_BRANCH: "mp/node_version"
   POSTGRES_HOSTNAME: postgres_${{ github.job }}_${{ inputs.deduplication_id }}_${{ github.run_id }}_${{ github.run_attempt }}
 
 permissions: