Skip to content

Commit 79f32b2

Browse files
committed
reverted back to sed, added double quotes to all variables
1 parent 91dc25f commit 79f32b2

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

.github/workflows/build-workspace-product-part.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -196,20 +196,20 @@ jobs:
196196
product_version=$(jq -rc '.version' ./package.json)
197197
echo "product_version=$product_version"
198198
199-
if [[ $product_version == *"SNAPSHOT"* ]]; then
199+
if [[ "$product_version" == *"SNAPSHOT"* ]]; then
200200
echo "replace SNAPSHOT in version with timestamp"
201-
product_version="${product_version/SNAPSHOT/$(date +%Y%m%d-%H%M%S)}"
201+
product_version=$(echo "$product_version" | sed "s/SNAPSHOT/$(date +%Y%m%d-%H%M%S)/g")
202202
echo "product_version=$product_version"
203203
fi
204204
205-
workspace_version=$(jq -rc '.version' ./tmp/$COMPONENT/package.json)
205+
workspace_version=$(jq -rc '.version' ./tmp/"$COMPONENT"/package.json)
206206
echo "workspace_version=$workspace_version"
207207
208-
if [[ $product_version != $workspace_version ]]; then
208+
if [[ "$product_version" != "$workspace_version" ]]; then
209209
echo "update workspace version"
210-
jq --arg version "$product_version" '.version = $version' ./tmp/$COMPONENT/package.json > ./tmp/$COMPONENT/package.json.tmp
211-
mv ./tmp/$COMPONENT/package.json.tmp ./tmp/$COMPONENT/package.json
212-
echo "workspace version updated to $(jq -rc '.version' ./tmp/$COMPONENT/package.json)"
210+
jq --arg version "$product_version" '.version = $version' ./tmp/"$COMPONENT"/package.json > ./tmp/"$COMPONENT"/package.json.tmp
211+
mv ./tmp/"$COMPONENT"/package.json.tmp ./tmp/"$COMPONENT"/package.json
212+
echo "workspace version updated to $(jq -rc '.version' ./tmp/"$COMPONENT"/package.json)"
213213
fi
214214
env:
215215
COMPONENT: ${{ inputs.component }}

0 commit comments

Comments
 (0)