Skip to content

Commit 7c607f2

Browse files
integrate feedback
1 parent 508df8b commit 7c607f2

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

.github/workflows/deploy-product.yml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,6 @@ jobs:
6767
dv_qms: ${{ secrets.DV_QMS }}
6868
actor: ${{ github.actor }}
6969
qms_are_allowed: "true"
70-
- name: Configure AWS Credentials
71-
uses: aws-actions/[email protected]
72-
with:
73-
role-to-assume: ${{ secrets.DV_AWS_ECR_ROLE }}
74-
aws_role: ${{ secrets.DV_AWS_ECR_ROLE }}
75-
aws-region: ${{ secrets.DV_AWS_REGION }}
76-
- name: Login to Amazon ECR
77-
id: login-ecr
78-
uses: aws-actions/[email protected]
7970
- uses: ./tmp/github-workflows/.github/actions/get-product-parameters
8071
id: get-parameters
8172
with:
@@ -93,9 +84,20 @@ jobs:
9384
ref: ${{ env.WORKFLOW_BRANCH }}
9485
github_user: ${{ secrets.DV_BOT_USER }}
9586
client_payload: '{ "app": "${{ steps.get-parameters.outputs.app }}", "customer": "${{ inputs.customer }}", "stage": "${{ inputs.stage }}", "sub_app": "${{ steps.get-parameters.outputs.sub_app }}", "branch": "${{ steps.get-parameters.outputs.image_tag2 }}", "add_revision_as_tag": "${{ fromJSON(inputs.add_revision_as_tag) }}" }'
87+
- name: Configure AWS Credentials
88+
if: ${{ inputs.add_revision_as_tag }} == true
89+
uses: aws-actions/[email protected]
90+
with:
91+
role-to-assume: ${{ secrets.DV_AWS_ECR_ROLE }}
92+
aws_role: ${{ secrets.DV_AWS_ECR_ROLE }}
93+
aws-region: ${{ secrets.DV_AWS_REGION }}
94+
- name: Login to Amazon ECR
95+
if: ${{ inputs.add_revision_as_tag }} == true
96+
id: login-ecr
97+
uses: aws-actions/[email protected]
9698
- name: get revision label
9799
id: get-revision-label
98-
if: ${{ inputs.add_revision_as_tag }} == true && ${{ inputs.customer }} == 'maze'
100+
if: ${{ inputs.add_revision_as_tag }} == true
99101
run: |
100102
echo "fetch labels of image"
101103
ECR_REPO=$(echo ${{ steps.get-parameters.outputs.ecr_repos }} | cut -d ',' -f 1)

0 commit comments

Comments
 (0)