Skip to content

Commit a5cc97f

Browse files
Copilotpuehringer
andcommitted
Rename 'env' to 'build_args' for better semantic accuracy
Co-authored-by: puehringer <[email protected]>
1 parent db3841c commit a5cc97f

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.github/workflows/build-docker-artifacts-config.schema.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@
4040
"default": true,
4141
"description": "Scan the image for high severity vulnerabilities"
4242
},
43-
"env": {
43+
"build_args": {
4444
"type": "object",
45-
"description": "Environment variables to pass as build arguments to Docker",
45+
"description": "Build arguments to pass to Docker",
4646
"additionalProperties": {
4747
"type": "string"
4848
}

.github/workflows/build-docker-artifacts.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,9 @@ jobs:
112112
image_tag_branch_name: imageTagBranchName,
113113
ecr_respositories: flavor.components.map(component => component.ecr_repository),
114114
components: flavor.components.map(component => {
115-
// Format env variables as build-args string
116-
const envBuildArgs = component.env ?
117-
Object.entries(component.env).map(([key, value]) => `${key}=${value}`).join('\n') : '';
115+
// Format build arguments as build-args string
116+
const formattedBuildArgs = component.build_args ?
117+
Object.entries(component.build_args).map(([key, value]) => `${key}=${value}`).join('\n') : '';
118118
119119
return {
120120
...component,
@@ -125,7 +125,7 @@ jobs:
125125
build_time: buildTime,
126126
image_tag: imageTag,
127127
image_tag_branch_name: imageTagBranchName,
128-
env_build_args: envBuildArgs,
128+
formatted_build_args: formattedBuildArgs,
129129
};
130130
}),
131131
};
@@ -226,7 +226,7 @@ jobs:
226226
DATAVISYN_PYTHON_BASE_IMAGE=${{ env.DATAVISYN_PYTHON_BASE_IMAGE }}
227227
NODE_BASE_IMAGE=${{ env.NODE_BASE_IMAGE }}
228228
DATAVISYN_NGINX_BASE_IMAGE=${{ env.DATAVISYN_NGINX_BASE_IMAGE }}
229-
${{ matrix.component.env_build_args }}
229+
${{ matrix.component.formatted_build_args }}
230230
secrets:
231231
# Mount the token as secret mount: https://docs.docker.com/build/ci/github-actions/secrets/#secret-mounts
232232
"github_token=${{ secrets.CHECKOUT_TOKEN || github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}"

0 commit comments

Comments
 (0)