Commit 8cacf5e
authored
Add destroy request call in close event to support SSE closing (#34)
### Developer Checklist (Definition of Done)
**Issue**
- [x] All acceptance criteria from the issue are met
- [x] Tested in latest Chrome/Firefox
**UI/UX/Vis**
- [ ] Requires UI/UX/Vis review
- [ ] Reviewer(s) are notified (_tag assignees_)
- [ ] Review has occurred (_link to notes_)
- [ ] Feedback is included in this PR
- [ ] Reviewer(s) approve of concept and design
**Code**
- [x] Branch is up-to-date with the branch to be merged with, i.e.,
develop
- [x] Code is cleaned up and formatted
- [x] Unit tests are written (frontend/backend if applicable)
- [x] Integration tests are written (if applicable)
**PR**
- [x] Descriptive title for this pull request is provided (will be used
for release notes later)
- [x] Reviewer and assignees are defined
- [x] Add type label (e.g., *bug*, *feature*) to this pull request
- [x] Add release label (e.g., `release: minor`) to this PR following
[semver](https://semver.org/)
- [x] The PR is connected to the corresponding issue (via `Closes #...`)
- [x] [Summary of changes](#summary-of-changes) is written
### Summary of changes
- Destroy the current request on close to properly close any open SSE
(server side events) sessions. Otherwise, the sessions will remain open
and never be closed, causing issues with the reload process hanging
infinitely.
### Screenshots
### Additional notes for the reviewer(s)
-
Thanks for creating this pull request 🤗1 file changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
320 | 320 | | |
321 | 321 | | |
322 | 322 | | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
323 | 327 | | |
324 | 328 | | |
325 | 329 | | |
| |||
0 commit comments