Skip to content

Commit fa7fdf2

Browse files
Fix: Add rsbuild polyfill plugin (#148)
Closes datavisyn/visyn_pro#395 ### Developer Checklist (Definition of Done) **Issue** - [ ] All acceptance criteria from the issue are met - [ ] Tested in latest Chrome/Firefox **UI/UX/Vis** - [ ] Requires UI/UX/Vis review - [ ] Reviewer(s) are notified (_tag assignees_) - [ ] Review has occurred (_link to notes_) - [ ] Feedback is included in this PR - [ ] Reviewer(s) approve of concept and design **Code** - [x] Branch is up-to-date with the branch to be merged with, i.e., develop - [ ] Code is cleaned up and formatted - [ ] Unit tests are written (frontend/backend if applicable) - [ ] Integration tests are written (if applicable) **PR** - [x] Descriptive title for this pull request is provided (will be used for release notes later) - [x] Reviewer and assignees are defined - [ ] Add type label (e.g., *bug*, *feature*) to this pull request - [x] Add release label (e.g., `release: minor`) to this PR following [semver](https://semver.org/) - [x] The PR is connected to the corresponding issue (via `Closes #...`) - [x] [Summary of changes](#summary-of-changes) is written ### Summary of changes - added @rsbuild/plugin-node-polyfill to fix datavisyn/visyn_pro#395 ### Screenshots ### Additional notes for the reviewer(s) - Thanks for creating this pull request 🤗
1 parent db114de commit fa7fdf2

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

config/storybook.rsbuild.config.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
import { defineConfig } from '@rsbuild/core';
2+
import { pluginNodePolyfill } from '@rsbuild/plugin-node-polyfill';
23
import { pluginReact } from '@rsbuild/plugin-react';
34
import { pluginSass } from '@rsbuild/plugin-sass';
45

56
// This is the rsbuild configuration used by storybook, it is not the same as the rspack config!
67
export default defineConfig({
7-
plugins: [pluginReact(), pluginSass()],
8+
plugins: [pluginReact(), pluginSass(), pluginNodePolyfill()],
89
});

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
"dependencies": {
3636
"@kesills/eslint-config-airbnb-typescript": "^20.0.0",
3737
"@rsbuild/core": "^1.2.0",
38+
"@rsbuild/plugin-node-polyfill": "^1.4.0",
3839
"@rsbuild/plugin-react": "^1.1.0",
3940
"@rsbuild/plugin-sass": "^1.2.0",
4041
"@rsdoctor/cli": "^0.4.13",

0 commit comments

Comments
 (0)